Add more Google domains to the list of domains which should have

chrome/browser/metrics/variations/variations_http_header_provider.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/metrics/variations/variations_http_header_provider.h"
 
 #include <vector>
 
 #include "base/base64.h"
 #include "base/memory/singleton.h"
@@ skipping 211 matching lines @@
                                      google_util::ALLOW_NON_STANDARD_PORTS)) {
     return true;
   }
 
   if (!url.is_valid() || !url.SchemeIsHTTPOrHTTPS())
     return false;
 
   // Some domains don't have international TLD extensions, so testing for them
   // is very straight forward.
   const std::string host = url.host();
-  if (EndsWith(host, ".doubleclick.net", false) ||
+  if (EndsWith(host, ".android.com", false) ||
+      EndsWith(host, ".doubleclick.com", false) ||
+      EndsWith(host, ".doubleclick.net", false) ||
+      EndsWith(host, ".ggpht.com", false) ||
+      EndsWith(host, ".googleadservices.com", false) ||
+      EndsWith(host, ".googleapis.com", false) ||
+      EndsWith(host, ".googleapis.com", false) ||

[Alexei Svitkine (slow), 2014/05/29 20:14:38]

This seems to be repeated.

[Ryan Hamilton, 2014/05/29 22:44:27]

Done.

       EndsWith(host, ".googlesyndication.com", false) ||
+      EndsWith(host, ".googleusercontent.com", false) ||
+      EndsWith(host, ".googlevideo.com", false) ||

[Alexei Svitkine (slow), 2014/05/29 20:14:38]

This seems to be just a redirect, do we really need it?

[Ryan Hamilton, 2014/05/29 22:44:27]

www.googlevideo.com may be a redirect, but there are lots of other hosts in this
domain that are not. This is the current primary domain from which youtube video
content is served.

+      EndsWith(host, ".gstatic.com", false) ||
+      EndsWith(host, ".youtube.com", false) ||

[Alexei Svitkine (slow), 2014/05/29 20:14:38]

Youtube is already being checked lower down.

[Ryan Hamilton, 2014/05/29 22:44:27]

Done.

+      EndsWith(host, ".ytimg.com", false) ||

[Ryan Hamilton, 2014/05/28 22:38:31]

If you prefer, we could stick these suffixes into a hash_set, and then check to
see if the suffix of the host is in the set?

[Alexei Svitkine (slow), 2014/05/29 00:08:54]

Yeah, that would be better if we really want that many domains here. By the way,
are all of these absolutely necessary? My understanding is you want to measure
the effect of QUIC acceleration on requests to these domains from the
server-side, hence why these are being added. So will you really look at metrics
at each one of those domains server-side?

I also wonder if perhaps it would make sense to have more fine-grained control
over these. Listing these domains here will result in all server-visible
experiments being sent as headers to them now - which will actually make many
web sessions a tiny bit slower (i.e. due to extra headers to all these popular 
sites).

Perhaps a better solution would be to have individual experiments list the
domains they care about in their configs - that way only QUIC can list these
specific sites, so the headers sent to them would be more minimal. WDYT?

[Ryan Hamilton, 2014/05/29 22:44:27]

That's the plan, yes.
Sounds good... But not as part of this CL, I think.

       LowerCaseEqualsASCII(host, "www.googleadservices.com")) {
     return true;
   }
 
   // The below mirrors logic in IsGoogleDomainUrl(), but for youtube.<TLD>.
   const size_t tld_length = net::registry_controlled_domains::GetRegistryLength(
       host,
       net::registry_controlled_domains::EXCLUDE_UNKNOWN_REGISTRIES,
       net::registry_controlled_domains::EXCLUDE_PRIVATE_REGISTRIES);
   if ((tld_length == 0) || (tld_length == std::string::npos))
     return false;
 
   const std::string host_minus_tld(host, 0, host.length() - tld_length);
   return LowerCaseEqualsASCII(host_minus_tld, "youtube.") ||
       EndsWith(host_minus_tld, ".youtube.", false);
 }
 
 }  // namespace chrome_variations