Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 307733002: use enum to specify deviceSource for fling animation (Closed)

Created:
6 years, 6 months ago by rjkroege
Modified:
6 years, 6 months ago
Reviewers:
dglazkov
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Visibility:
Public.

Description

use enum to specify deviceSource for fling animation Patch 1 of 4 to specify the deviceSource of a desired fling animation request via enum throughout Blink and Chromium. BUG=343327 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175151

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -14 lines) Patch
M Source/web/WebInputEventFactoryMac.mm View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebViewImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M public/platform/Platform.h View 2 chunks +10 lines, -0 lines 2 comments Download
A + public/platform/WebGestureDevice.h View 2 chunks +7 lines, -8 lines 0 comments Download
M public/web/WebActiveWheelFlingParameters.h View 2 chunks +5 lines, -2 lines 0 comments Download
M public/web/WebInputEvent.h View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
rjkroege
Please take a look. Hopefully this fixes the layering violation in the associated bug. Note ...
6 years, 6 months ago (2014-05-28 23:38:36 UTC) #1
rjkroege
Adam is away. Do you mind taking a look?
6 years, 6 months ago (2014-05-29 22:45:15 UTC) #2
dglazkov
lgtm https://codereview.chromium.org/307733002/diff/1/public/platform/Platform.h File public/platform/Platform.h (right): https://codereview.chromium.org/307733002/diff/1/public/platform/Platform.h#newcode599 public/platform/Platform.h:599: // TODO(rjkroege): Remove at end of http://crbug.com/343327 This ...
6 years, 6 months ago (2014-05-30 00:00:09 UTC) #3
rjkroege
https://codereview.chromium.org/307733002/diff/1/public/platform/Platform.h File public/platform/Platform.h (right): https://codereview.chromium.org/307733002/diff/1/public/platform/Platform.h#newcode599 public/platform/Platform.h:599: // TODO(rjkroege): Remove at end of http://crbug.com/343327 On 2014/05/30 ...
6 years, 6 months ago (2014-05-30 01:00:20 UTC) #4
rjkroege
The CQ bit was checked by rjkroege@chromium.org
6 years, 6 months ago (2014-05-30 01:01:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rjkroege@chromium.org/307733002/1
6 years, 6 months ago (2014-05-30 01:03:06 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-05-30 16:00:16 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 16:38:51 UTC) #8
Message was sent while issue was closed.
Change committed as 175151

Powered by Google App Engine
This is Rietveld 408576698