Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 304793003: use enum to specify deviceSource for fling animation. (Closed)

Created:
6 years, 6 months ago by rjkroege
Modified:
6 years, 6 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, yusukes+watch_chromium.org, nasko+codewatch_chromium.org, sievers+watch_chromium.org, yukishiino+watch_chromium.org, aandrey+blink_chromium.org, jdduke+watch_chromium.org, miu+watch_chromium.org, vsevik, jam, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, kalyank, creis+watch_chromium.org, penghuang+watch_chromium.org, paulirish+reviews_chromium.org, piman+watch_chromium.org, yurys, danakj+watch_chromium.org, James Su, pfeldman, dglazkov
Visibility:
Public.

Description

use enum to specify deviceSource for fling animation. Patch 2 of 4 to specify the deviceSource of a desired fling animation request via enum throughout Blink and Chromium. BUG=343327 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274643

Patch Set 1 #

Patch Set 2 : removed desired #include #

Total comments: 1

Patch Set 3 : fixed result of sed typo #

Patch Set 4 : rebased for parallel breaking changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+334 lines, -308 lines) Patch
M content/browser/devtools/renderer_overrides_handler.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/gesture_event_queue.cc View 1 2 3 3 chunks +6 lines, -3 lines 0 comments Download
M content/browser/renderer_host/input/gesture_event_queue_unittest.cc View 1 2 3 36 chunks +74 lines, -71 lines 0 comments Download
M content/browser/renderer_host/input/input_router_impl.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/input_router_impl_unittest.cc View 1 2 24 chunks +65 lines, -58 lines 0 comments Download
M content/browser/renderer_host/input/touch_action_filter.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/touch_action_filter_unittest.cc View 1 2 16 chunks +35 lines, -35 lines 0 comments Download
M content/browser/renderer_host/input/touch_emulator.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/web_input_event_builders_android.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/web_input_event_util.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_unittest.cc View 1 2 3 6 chunks +10 lines, -11 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 1 2 3 30 chunks +42 lines, -40 lines 0 comments Download
M content/browser/renderer_host/ui_events_helper.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/web_input_event_aura.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/blink_platform_impl.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/child/blink_platform_impl.cc View 1 2 3 chunks +2 lines, -3 lines 0 comments Download
M content/common/input/input_event_stream_validator.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/common/input/synthetic_web_input_event_builders.h View 2 chunks +4 lines, -5 lines 0 comments Download
M content/common/input/synthetic_web_input_event_builders.cc View 1 2 3 5 chunks +5 lines, -5 lines 0 comments Download
M content/renderer/input/input_handler_proxy.cc View 1 2 7 chunks +16 lines, -9 lines 0 comments Download
M content/renderer/input/input_handler_proxy_client.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/input/input_handler_proxy_unittest.cc View 1 2 42 chunks +48 lines, -42 lines 0 comments Download
M content/renderer/input/input_handler_wrapper.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/input/input_handler_wrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_widget_fullscreen_pepper.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/test/test_webkit_platform_support.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/test_webkit_platform_support.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
rjkroege
This is the Chrome side CL following https://codereview.chromium.org/307733002/ Can you take a look to make ...
6 years, 6 months ago (2014-05-28 23:47:09 UTC) #1
rjkroege
Once again: could you take a look instead? In particular, the changes to content/child/* which ...
6 years, 6 months ago (2014-05-29 22:49:07 UTC) #2
dglazkov
I am not the right guy -- don't have the owners thingy in these lands.
6 years, 6 months ago (2014-05-29 23:58:58 UTC) #3
rjkroege
jam@: can you review this? It's code cleanup: all about breaking one dependency. https://codereview.chromium.org/304793003/diff/20001/content/child/blink_platform_impl.cc File ...
6 years, 6 months ago (2014-05-30 14:43:42 UTC) #4
jam
rerouting to Avi
6 years, 6 months ago (2014-05-30 19:18:13 UTC) #5
Avi (use Gerrit)
stamp lgtm
6 years, 6 months ago (2014-05-30 19:40:19 UTC) #6
rjkroege
The CQ bit was checked by rjkroege@chromium.org
6 years, 6 months ago (2014-06-02 14:23:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rjkroege@chromium.org/304793003/20001
6 years, 6 months ago (2014-06-02 14:24:25 UTC) #8
rjkroege
The CQ bit was unchecked by rjkroege@chromium.org
6 years, 6 months ago (2014-06-02 17:44:48 UTC) #9
rjkroege
Do you want to have another look?
6 years, 6 months ago (2014-06-03 14:32:41 UTC) #10
rjkroege
The CQ bit was checked by rjkroege@chromium.org
6 years, 6 months ago (2014-06-03 21:00:17 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rjkroege@chromium.org/304793003/60001
6 years, 6 months ago (2014-06-03 21:02:20 UTC) #12
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 21:53:35 UTC) #13
Message was sent while issue was closed. 
Change committed as 274643

Powered by Google App Engine
This is Rietveld 408576698