Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2098)

Unified Diff: chrome/browser/extensions/extensions_ui.cc

Issue 3077022: Extension package creation cleanup (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: Now with proper threading Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extensions_ui.cc
diff --git a/chrome/browser/extensions/extensions_ui.cc b/chrome/browser/extensions/extensions_ui.cc
index 68c61106496816f6116a7706ce4d4d472f696191..e48274a229829a51f42ed5089ddfc8d138149a4d 100644
--- a/chrome/browser/extensions/extensions_ui.cc
+++ b/chrome/browser/extensions/extensions_ui.cc
@@ -626,6 +626,8 @@ void ExtensionsDOMHandler::HandlePackMessage(const Value* value) {
void ExtensionsDOMHandler::OnPackSuccess(const FilePath& crx_file,
const FilePath& pem_file) {
std::string message;
+ // TODO we probably shouldn't use ToWStringHack() -- what's the right thing to
+ // do?
if (!pem_file.empty()) {
message = WideToUTF8(l10n_util::GetStringF(
IDS_EXTENSION_PACK_DIALOG_SUCCESS_BODY_NEW,
@@ -642,8 +644,8 @@ void ExtensionsDOMHandler::OnPackSuccess(const FilePath& crx_file,
dom_ui_->CallJavascriptFunction(L"hidePackDialog", results);
}
-void ExtensionsDOMHandler::OnPackFailure(const std::wstring& error) {
- ShowAlert(WideToUTF8(error));
+void ExtensionsDOMHandler::OnPackFailure(const std::string& error) {
+ ShowAlert(error);
}
void ExtensionsDOMHandler::HandleAutoUpdateMessage(const Value* value) {

Powered by Google App Engine
This is Rietveld 408576698