Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: chrome/browser/extensions/pack_extension_job.h

Issue 3077022: Extension package creation cleanup (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: Now with proper threading Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/pack_extension_job.h
diff --git a/chrome/browser/extensions/pack_extension_job.h b/chrome/browser/extensions/pack_extension_job.h
index 3c7925c3e59f139fecabf227fe6c4fd97e90474a..092c899b79af4b2d7aff366472dc9e05d61e0487 100644
--- a/chrome/browser/extensions/pack_extension_job.h
+++ b/chrome/browser/extensions/pack_extension_job.h
@@ -23,7 +23,7 @@ class PackExtensionJob : public base::RefCountedThreadSafe<PackExtensionJob> {
public:
virtual void OnPackSuccess(const FilePath& crx_file,
const FilePath& key_file) = 0;
- virtual void OnPackFailure(const std::wstring& message) = 0;
+ virtual void OnPackFailure(const std::string& message) = 0;
protected:
virtual ~Client() {}
@@ -47,8 +47,8 @@ class PackExtensionJob : public base::RefCountedThreadSafe<PackExtensionJob> {
~PackExtensionJob() {}
void RunOnFileThread();
- void ReportSuccessOnUIThread();
- void ReportFailureOnUIThread(const std::string& error);
+ void ReportSuccessOnClientThread();
+ void ReportFailureOnClientThread(const std::string& error);
ChromeThread::ID client_thread_id_;
Client* client_;

Powered by Google App Engine
This is Rietveld 408576698