tools/testing/dart/test_suite.dart - Issue 307693004: Fix again long paths in windows - seems that we had an off by one error in this

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/testing/dart/test_suite.dart

Issue 307693004: Fix again long paths in windows - seems that we had an off by one error in this (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/testing/dart/test_suite.dart

diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart

index dc489f1ce30c20bc11b6703c563586b179f8a078..632cfece25a5b8729ed5edf431159c03a5c4fd36 100644

--- a/tools/testing/dart/test_suite.dart

+++ b/tools/testing/dart/test_suite.dart

@@ -2152,7 +2152,7 @@ class TestUtils {

path = path.replaceAll('/', '_');

final int WINDOWS_SHORTEN_PATH_LIMIT = 60;

if (Platform.operatingSystem == 'windows' &&

- path.length > WINDOWS_SHORTEN_PATH_LIMIT) {

+ path.length >= WINDOWS_SHORTEN_PATH_LIMIT) {

for (var key in PATH_REPLACEMENTS.keys) {

if (path.startsWith(key)) {

path = path.replaceFirst(key, PATH_REPLACEMENTS[key]);

« no previous file with comments | « no previous file | no next file » | no next file with comments »