Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: tools/testing/dart/test_suite.dart

Issue 307693004: Fix again long paths in windows - seems that we had an off by one error in this (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * Classes and methods for enumerating and preparing tests. 6 * Classes and methods for enumerating and preparing tests.
7 * 7 *
8 * This library includes: 8 * This library includes:
9 * 9 *
10 * - Creating tests by listing all the Dart files in certain directories, 10 * - Creating tests by listing all the Dart files in certain directories,
(...skipping 2134 matching lines...) Expand 10 before | Expand all | Expand 10 after
2145 2145
2146 // Some tests are already in [build_dir]/generated_tests. 2146 // Some tests are already in [build_dir]/generated_tests.
2147 String GEN_TESTS = 'generated_tests/'; 2147 String GEN_TESTS = 'generated_tests/';
2148 if (path.contains(GEN_TESTS)) { 2148 if (path.contains(GEN_TESTS)) {
2149 int index = path.indexOf(GEN_TESTS) + GEN_TESTS.length; 2149 int index = path.indexOf(GEN_TESTS) + GEN_TESTS.length;
2150 path = 'multitest/${path.substring(index)}'; 2150 path = 'multitest/${path.substring(index)}';
2151 } 2151 }
2152 path = path.replaceAll('/', '_'); 2152 path = path.replaceAll('/', '_');
2153 final int WINDOWS_SHORTEN_PATH_LIMIT = 60; 2153 final int WINDOWS_SHORTEN_PATH_LIMIT = 60;
2154 if (Platform.operatingSystem == 'windows' && 2154 if (Platform.operatingSystem == 'windows' &&
2155 path.length > WINDOWS_SHORTEN_PATH_LIMIT) { 2155 path.length >= WINDOWS_SHORTEN_PATH_LIMIT) {
2156 for (var key in PATH_REPLACEMENTS.keys) { 2156 for (var key in PATH_REPLACEMENTS.keys) {
2157 if (path.startsWith(key)) { 2157 if (path.startsWith(key)) {
2158 path = path.replaceFirst(key, PATH_REPLACEMENTS[key]); 2158 path = path.replaceFirst(key, PATH_REPLACEMENTS[key]);
2159 break; 2159 break;
2160 } 2160 }
2161 } 2161 }
2162 } 2162 }
2163 return path; 2163 return path;
2164 } 2164 }
2165 } 2165 }
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
2226 * $pass tests are expected to pass 2226 * $pass tests are expected to pass
2227 * $failOk tests are expected to fail that we won't fix 2227 * $failOk tests are expected to fail that we won't fix
2228 * $fail tests are expected to fail that we should fix 2228 * $fail tests are expected to fail that we should fix
2229 * $crash tests are expected to crash that we should fix 2229 * $crash tests are expected to crash that we should fix
2230 * $timeout tests are allowed to timeout 2230 * $timeout tests are allowed to timeout
2231 * $compileErrorSkip tests are skipped on browsers due to compile-time error 2231 * $compileErrorSkip tests are skipped on browsers due to compile-time error
2232 """; 2232 """;
2233 print(report); 2233 print(report);
2234 } 2234 }
2235 } 2235 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698