Remove passwords from the keychain if profile is destroyed.

Remove passwords from the keychain if profile is destroyed.

BUG=343891
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274205

[vasilii, 2014-05-28 18:00:46]

Hi guys,

please review the CL.

[Elliot Glaysher, 2014-05-28 19:10:34]

the profiles code l g t m, but I'm not entirely convinced that we should be
deleting users passwords from the keyring.

[Garrett Casto, 2014-05-28 20:32:10]

LGTM.

For the record there is still cross profile password sharing on Mac that we
probably want to do something about (crbug.com/357223).

[Elliot Glaysher, 2014-05-28 20:53:52]

gcasto: I can't read that bug. Could you cc me for context?

[chromium-reviews, 2014-05-28 20:58:00]

Whoops, typo. crbug.com/357233.


On Wed, May 28, 2014 at 1:53 PM, <erg@chromium.org> wrote:

> gcasto: I can't read that bug. Could you cc me for context?
>
> https://codereview.chromium.org/307673002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Elliot Glaysher, 2014-05-28 21:20:46]

lgtm for the code; I'll defer to the password manager owner for the rest.

[vasilii, 2014-06-02 07:52:08]

The CQ bit was checked by vasilii@chromium.org

[commit-bot: I haz the power, 2014-06-02 07:52:37]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vasilii@chromium.org/307673002/20001

[commit-bot: I haz the power, 2014-06-02 09:12:46]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)

[commit-bot: I haz the power, 2014-06-02 11:22:02]

Change committed as 274205