Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2605)

Unified Diff: chrome/browser/profiles/profile_manager_browsertest.cc

Issue 307673002: Remove passwords from the keychain if profile is destroyed. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add RunAllPendingInMessageLoop Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/profiles/profile_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/profiles/profile_manager_browsertest.cc
diff --git a/chrome/browser/profiles/profile_manager_browsertest.cc b/chrome/browser/profiles/profile_manager_browsertest.cc
index 9c95d5a27af03377e598db8dd7dd3a28b3a15798..42e83480ad5a6c3a0abaad13fccaccac2d06323e 100644
--- a/chrome/browser/profiles/profile_manager_browsertest.cc
+++ b/chrome/browser/profiles/profile_manager_browsertest.cc
@@ -6,6 +6,7 @@
#include "base/command_line.h"
#include "base/prefs/pref_service.h"
#include "base/strings/utf_string_conversions.h"
+#include "chrome/browser/password_manager/password_store_factory.h"
#include "chrome/browser/profiles/profile_info_cache.h"
#include "chrome/browser/profiles/profile_info_cache_observer.h"
#include "chrome/browser/profiles/profile_manager.h"
@@ -20,6 +21,9 @@
#include "chrome/test/base/test_switches.h"
#include "chrome/test/base/testing_browser_process.h"
#include "chrome/test/base/ui_test_utils.h"
+#include "components/autofill/core/common/password_form.h"
+#include "components/password_manager/core/browser/password_store.h"
+#include "components/password_manager/core/browser/password_store_consumer.h"
#if defined(OS_CHROMEOS)
#include "base/path_service.h"
@@ -85,6 +89,29 @@ class ProfileRemovalObserver : public ProfileInfoCacheObserver {
DISALLOW_COPY_AND_ASSIGN(ProfileRemovalObserver);
};
+class PasswordStoreConsumerVerifier :
+ public password_manager::PasswordStoreConsumer {
+ public:
+ PasswordStoreConsumerVerifier() : called_(false) {}
+
+ virtual void OnGetPasswordStoreResults(
+ const std::vector<autofill::PasswordForm*>& results) OVERRIDE {
+ EXPECT_FALSE(called_);
+ called_ = true;
+ password_entries_.clear();
+ password_entries_.assign(results.begin(), results.end());
+ }
+
+ bool IsCalled() const { return called_; }
+
+ const std::vector<autofill::PasswordForm*>& GetPasswords() const {
+ return password_entries_.get();
+ }
+ private:
+ ScopedVector<autofill::PasswordForm> password_entries_;
+ bool called_;
+};
+
} // namespace
// This file contains tests for the ProfileManager that require a heavyweight
@@ -368,3 +395,49 @@ IN_PROC_BROWSER_TEST_F(ProfileManagerBrowserTest, EphemeralProfile) {
EXPECT_EQ(1U, browser_list->size());
ASSERT_EQ(1U, cache.GetNumberOfProfiles());
}
+
+IN_PROC_BROWSER_TEST_F(ProfileManagerBrowserTest, DeletePasswords) {
+ Profile* profile = ProfileManager::GetActiveUserProfile();
+ ASSERT_TRUE(profile);
+
+ autofill::PasswordForm form;
+ form.scheme = autofill::PasswordForm::SCHEME_HTML;
+ form.origin = GURL("http://accounts.google.com/LoginAuth");
+ form.signon_realm = "http://accounts.google.com/";
+ form.username_value = base::ASCIIToUTF16("my_username");
+ form.password_value = base::ASCIIToUTF16("my_password");
+ form.ssl_valid = false;
+ form.preferred = true;
+ form.blacklisted_by_user = false;
+
+ scoped_refptr<password_manager::PasswordStore> password_store =
+ PasswordStoreFactory::GetForProfile(profile, Profile::EXPLICIT_ACCESS)
+ .get();
+ ASSERT_TRUE(password_store);
+
+ password_store->AddLogin(form);
+ PasswordStoreConsumerVerifier verify_add;
+ password_store->GetAutofillableLogins(&verify_add);
+
+ ProfileManager* profile_manager = g_browser_process->profile_manager();
+ profile_manager->ScheduleProfileForDeletion(profile->GetPath(),
+ ProfileManager::CreateCallback());
+ content::RunAllPendingInMessageLoop();
+ PasswordStoreConsumerVerifier verify_delete;
+ password_store->GetAutofillableLogins(&verify_delete);
+
+ // Run the password background thread.
+ base::RunLoop run_loop;
+ base::Closure task = base::Bind(
+ base::IgnoreResult(&content::BrowserThread::PostTask),
+ content::BrowserThread::UI,
+ FROM_HERE,
+ run_loop.QuitClosure());
+ EXPECT_TRUE(password_store->ScheduleTask(task));
+ run_loop.Run();
+
+ EXPECT_TRUE(verify_add.IsCalled());
+ EXPECT_EQ(1u, verify_add.GetPasswords().size());
+ EXPECT_TRUE(verify_delete.IsCalled());
+ EXPECT_EQ(0u, verify_delete.GetPasswords().size());
+}
« no previous file with comments | « chrome/browser/profiles/profile_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698