Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 307653004: IndexedDB: Result of failed request should be |undefined| (Closed)

Created:
6 years, 6 months ago by jsbell
Modified:
6 years, 6 months ago
Reviewers:
ericu, cmumford
CC:
blink-reviews, dgrogan, jsbell+idb_chromium.org, alecflett, ericu+idb_chromium.org, cmumford
Visibility:
Public.

Description

IndexedDB: Result of failed request should be |undefined| Per spec, after an error the |result| should always be |undefined|. Chromium was yielding |null| or an obsolete value instead. BUG=378411 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174997

Patch Set 1 #

Messages

Total messages: 5 (0 generated)
jsbell
I noticed the edge case of a failed IDBOpenDBRequest's result after error while poking at ...
6 years, 6 months ago (2014-05-28 18:44:17 UTC) #1
ericu
LGTM "result of type any, readonly When the done flag is true, getting this property ...
6 years, 6 months ago (2014-05-28 20:28:04 UTC) #2
jsbell
The CQ bit was checked by jsbell@chromium.org
6 years, 6 months ago (2014-05-28 20:42:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/307653004/1
6 years, 6 months ago (2014-05-28 20:43:20 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-05-28 21:23:13 UTC) #5
Message was sent while issue was closed.
Change committed as 174997

Powered by Google App Engine
This is Rietveld 408576698