Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Side by Side Diff: Source/modules/indexeddb/IDBRequest.cpp

Issue 307653004: IndexedDB: Result of failed request should be |undefined| (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « LayoutTests/storage/indexeddb/transaction-error-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 216 matching lines...) Expand 10 before | Expand all | Expand 10 after
227 return true; 227 return true;
228 } 228 }
229 229
230 void IDBRequest::onError(PassRefPtrWillBeRawPtr<DOMError> error) 230 void IDBRequest::onError(PassRefPtrWillBeRawPtr<DOMError> error)
231 { 231 {
232 IDB_TRACE("IDBRequest::onError()"); 232 IDB_TRACE("IDBRequest::onError()");
233 if (!shouldEnqueueEvent()) 233 if (!shouldEnqueueEvent())
234 return; 234 return;
235 235
236 m_error = error; 236 m_error = error;
237 setResult(IDBAny::createUndefined());
237 m_pendingCursor.clear(); 238 m_pendingCursor.clear();
238 enqueueEvent(Event::createCancelableBubble(EventTypeNames::error)); 239 enqueueEvent(Event::createCancelableBubble(EventTypeNames::error));
239 } 240 }
240 241
241 void IDBRequest::onSuccess(const Vector<String>& stringList) 242 void IDBRequest::onSuccess(const Vector<String>& stringList)
242 { 243 {
243 IDB_TRACE("IDBRequest::onSuccess(StringList)"); 244 IDB_TRACE("IDBRequest::onSuccess(StringList)");
244 if (!shouldEnqueueEvent()) 245 if (!shouldEnqueueEvent())
245 return; 246 return;
246 247
(...skipping 292 matching lines...) Expand 10 before | Expand all | Expand 10 after
539 540
540 void IDBRequest::dequeueEvent(Event* event) 541 void IDBRequest::dequeueEvent(Event* event)
541 { 542 {
542 for (size_t i = 0; i < m_enqueuedEvents.size(); ++i) { 543 for (size_t i = 0; i < m_enqueuedEvents.size(); ++i) {
543 if (m_enqueuedEvents[i].get() == event) 544 if (m_enqueuedEvents[i].get() == event)
544 m_enqueuedEvents.remove(i); 545 m_enqueuedEvents.remove(i);
545 } 546 }
546 } 547 }
547 548
548 } // namespace WebCore 549 } // namespace WebCore
OLDNEW
« no previous file with comments | « LayoutTests/storage/indexeddb/transaction-error-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698