Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 307623004: Move DetailedConsoleMessageAdded from ChromeRVO to ChromeRFO. (Closed)

Created:
6 years, 6 months ago by mkosiba (inactive)
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Move DetailedConsoleMessageAdded from ChromeRVO to ChromeRFO. BUG=304341 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274218

Patch Set 1 #

Patch Set 2 : make tests pass #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -101 lines) Patch
M chrome/browser/extensions/chrome_extension_web_contents_observer.h View 1 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/extensions/chrome_extension_web_contents_observer.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/extensions/tab_helper.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/tab_helper.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/renderer/chrome_render_frame_observer.h View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/renderer/chrome_render_frame_observer.cc View 1 4 chunks +74 lines, -0 lines 0 comments Download
M chrome/renderer/chrome_render_view_observer.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/renderer/chrome_render_view_observer.cc View 4 chunks +0 lines, -77 lines 0 comments Download
M content/public/renderer/render_view_observer.h View 1 1 chunk +0 lines, -12 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
mkosiba (inactive)
PTAL
6 years, 6 months ago (2014-05-28 16:27:45 UTC) #1
mkosiba (inactive)
PTAL
6 years, 6 months ago (2014-05-28 16:27:46 UTC) #2
sky
LGTM
6 years, 6 months ago (2014-05-28 16:58:27 UTC) #3
mkosiba (inactive)
looks like this needs some more changes to make it work right. +kalman for chrome/browser/extensions ...
6 years, 6 months ago (2014-05-29 17:00:31 UTC) #4
not at google - send to devlin
lgtm
6 years, 6 months ago (2014-05-29 18:14:33 UTC) #5
jochen (gone - plz use gerrit)
lgtm
6 years, 6 months ago (2014-06-02 07:30:33 UTC) #6
mkosiba (inactive)
The CQ bit was checked by mkosiba@chromium.org
6 years, 6 months ago (2014-06-02 08:44:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkosiba@chromium.org/307623004/20001
6 years, 6 months ago (2014-06-02 08:45:05 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_rel_device on tryserver.chromium ...
6 years, 6 months ago (2014-06-02 12:32:49 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 12:47:07 UTC) #10
Message was sent while issue was closed.
Change committed as 274218

Powered by Google App Engine
This is Rietveld 408576698