Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Side by Side Diff: content/public/renderer/render_view_observer.h

Issue 307623004: Move DetailedConsoleMessageAdded from ChromeRVO to ChromeRFO. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: make tests pass Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/renderer/chrome_render_view_observer.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_RENDERER_RENDER_VIEW_OBSERVER_H_ 5 #ifndef CONTENT_PUBLIC_RENDERER_RENDER_VIEW_OBSERVER_H_
6 #define CONTENT_PUBLIC_RENDERER_RENDER_VIEW_OBSERVER_H_ 6 #define CONTENT_PUBLIC_RENDERER_RENDER_VIEW_OBSERVER_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "content/common/content_export.h" 10 #include "content/common/content_export.h"
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
82 virtual void ZoomLevelChanged() {}; 82 virtual void ZoomLevelChanged() {};
83 virtual void DidChangeScrollOffset(blink::WebLocalFrame* frame) {} 83 virtual void DidChangeScrollOffset(blink::WebLocalFrame* frame) {}
84 virtual void DraggableRegionsChanged(blink::WebFrame* frame) {} 84 virtual void DraggableRegionsChanged(blink::WebFrame* frame) {}
85 virtual void DidCommitCompositorFrame() {} 85 virtual void DidCommitCompositorFrame() {}
86 virtual void DidUpdateLayout() {} 86 virtual void DidUpdateLayout() {}
87 87
88 // These match the RenderView methods. 88 // These match the RenderView methods.
89 virtual void DidHandleMouseEvent(const blink::WebMouseEvent& event) {} 89 virtual void DidHandleMouseEvent(const blink::WebMouseEvent& event) {}
90 virtual void DidHandleTouchEvent(const blink::WebTouchEvent& event) {} 90 virtual void DidHandleTouchEvent(const blink::WebTouchEvent& event) {}
91 91
92 // Called when we receive a console message from WebKit for which we requested
93 // extra details (like the stack trace). |message| is the error message,
94 // |source| is the WebKit-reported source of the error (either external or
95 // internal), and |stack_trace| is the stack trace of the error in a
96 // human-readable format (each frame is formatted as
97 // "\n at function_name (source:line_number:column_number)").
98 virtual void DetailedConsoleMessageAdded(const base::string16& message,
99 const base::string16& source,
100 const base::string16& stack_trace,
101 int32 line_number,
102 int32 severity_level) {}
103
104 // These match incoming IPCs. 92 // These match incoming IPCs.
105 virtual void Navigate(const GURL& url) {} 93 virtual void Navigate(const GURL& url) {}
106 virtual void ClosePage() {} 94 virtual void ClosePage() {}
107 virtual void OrientationChangeEvent() {} 95 virtual void OrientationChangeEvent() {}
108 96
109 virtual void OnStop() {} 97 virtual void OnStop() {}
110 98
111 // IPC::Listener implementation. 99 // IPC::Listener implementation.
112 virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE; 100 virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
113 101
(...skipping 17 matching lines...) Expand all
131 RenderView* render_view_; 119 RenderView* render_view_;
132 // The routing ID of the associated RenderView. 120 // The routing ID of the associated RenderView.
133 int routing_id_; 121 int routing_id_;
134 122
135 DISALLOW_COPY_AND_ASSIGN(RenderViewObserver); 123 DISALLOW_COPY_AND_ASSIGN(RenderViewObserver);
136 }; 124 };
137 125
138 } // namespace content 126 } // namespace content
139 127
140 #endif // CONTENT_PUBLIC_RENDERER_RENDER_VIEW_OBSERVER_H_ 128 #endif // CONTENT_PUBLIC_RENDERER_RENDER_VIEW_OBSERVER_H_
OLDNEW
« no previous file with comments | « chrome/renderer/chrome_render_view_observer.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698