Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4769)

Unified Diff: chrome/browser/extensions/api/networking_private/networking_private_process_client.h

Issue 30753002: Move GetVisibleNetworks network type filtering to WiFiService interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address codereview comments. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/networking_private/networking_private_process_client.h
diff --git a/chrome/browser/extensions/api/networking_private/networking_private_process_client.h b/chrome/browser/extensions/api/networking_private/networking_private_process_client.h
index 759e41e0bcfe96529a16bc741d936603821ee58c..ce3d4997cc3facd3cdedc81595820cbd4d391a9e 100644
--- a/chrome/browser/extensions/api/networking_private/networking_private_process_client.h
+++ b/chrome/browser/extensions/api/networking_private/networking_private_process_client.h
@@ -87,27 +87,27 @@ class NetworkingPrivateProcessClient
explicit NetworkingPrivateProcessClient(Profile* profile);
- // Gets the properties of the network with id |service_path|. See note on
+ // Gets the properties of the network with id |network_guid|. See note on
// |callback| and |error_callback|, in class description above.
- void GetProperties(const std::string& service_path,
+ void GetProperties(const std::string& network_guid,
const DictionaryResultCallback& callback,
const ErrorCallback& error_callback);
- // Start connect to the network with id |service_path|. See note on
+ // Start connect to the network with id |network_guid|. See note on
// |callback| and |error_callback|, in class description above.
- void StartConnect(const std::string& service_path,
+ void StartConnect(const std::string& network_guid,
const VoidResultCallback& callback,
const ErrorCallback& error_callback);
- // Start disconnect from the network with id |service_path|. See note on
+ // Start disconnect from the network with id |network_guid|. See note on
// |callback| and |error_callback|, in class description above.
- void StartDisconnect(const std::string& service_path,
+ void StartDisconnect(const std::string& network_guid,
const VoidResultCallback& callback,
const ErrorCallback& error_callback);
- // Sets the |properties| of the network with id |service_path|. See note on
+ // Sets the |properties| of the network with id |network_guid|. See note on
// |callback| and |error_callback|, in class description above.
- void SetProperties(const std::string& service_path,
+ void SetProperties(const std::string& network_guid,
const base::DictionaryValue& properties,
const VoidResultCallback& callback,
const ErrorCallback& error_callback);
@@ -115,8 +115,9 @@ class NetworkingPrivateProcessClient
// Requests network scan. Broadcasts NetworkListChangedEvent upon completion.
void RequestNetworkScan();
- // Gets the list of visible networks and calls |callback|.
- void GetVisibleNetworks(const ListResultCallback& callback);
+ // Gets the list of visible networks of |network_type| and calls |callback|.
+ void GetVisibleNetworks(const std::string& network_type,
+ const ListResultCallback& callback);
// Verify that Chromecast provides valid cryptographically signed properties.
void VerifyDestination(scoped_ptr<base::ListValue> args,

Powered by Google App Engine
This is Rietveld 408576698