Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1248)

Issue 307263002: [Telemetry] Retire JSGameBench. (Closed)

Created:
6 years, 6 months ago by tonyg
Modified:
6 years, 6 months ago
CC:
chromium-reviews, telemetry+watch_chromium.org, Miguel Garcia
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Telemetry] Retire JSGameBench. As of May 14, 2014, this benchmark is no longer maintained. https://github.com/facebookarchive/jsgamebench/commit/3938f9893d8713c47032d8d98bac41c32f4545ec I think it is time we thank it for all the fish (e.g. http://crbug.com/161828) and turn our eyes towards new benchmarks. My motivation for pursuing this is that it has a long cycle time and is flaky in many places. BUG= NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274272

Patch Set 1 #

Total comments: 1

Patch Set 2 : typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M tools/perf/benchmarks/jsgamebench.py View 1 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tonyg
6 years, 6 months ago (2014-06-02 17:17:17 UTC) #1
Sami
(+miguelg@ for FYI) lgtm. I think there are a few references to this on a ...
6 years, 6 months ago (2014-06-02 17:30:54 UTC) #2
Sami
https://codereview.chromium.org/307263002/diff/1/tools/perf/benchmarks/jsgamebench.py File tools/perf/benchmarks/jsgamebench.py (right): https://codereview.chromium.org/307263002/diff/1/tools/perf/benchmarks/jsgamebench.py#newcode10 tools/perf/benchmarks/jsgamebench.py:10: The benchmark is kept here for historical purpuses but ...
6 years, 6 months ago (2014-06-02 17:31:01 UTC) #3
tonyg
> I think you meant asteroids and/or spaceships. heh, heh, I meant in the Douglas ...
6 years, 6 months ago (2014-06-02 17:40:06 UTC) #4
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 6 months ago (2014-06-02 17:40:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/307263002/20001
6 years, 6 months ago (2014-06-02 17:41:15 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 17:42:53 UTC) #7
Message was sent while issue was closed.
Change committed as 274272

Powered by Google App Engine
This is Rietveld 408576698