Source/core/editing/CompositeEditCommand.h - Issue 307243004: Avoid calling slower Node::firstChild() / Node::lastChild() when possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/CompositeEditCommand.h

Issue 307243004: Avoid calling slower Node::firstChild() / Node::lastChild() when possible (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/CompositeEditCommand.h

diff --git a/Source/core/editing/CompositeEditCommand.h b/Source/core/editing/CompositeEditCommand.h

index 8b62ddda4cb7ac477232a82daecc8b8831459d7a..04506d64dcc24d61859f54f2630a79d49beaab49 100644

--- a/Source/core/editing/CompositeEditCommand.h

+++ b/Source/core/editing/CompositeEditCommand.h

@@ -146,9 +146,9 @@ protected:

PassRefPtrWillBeRawPtr<Node> addBlockPlaceholderIfNeeded(Element*);

void removePlaceholderAt(const Position&);

- PassRefPtrWillBeRawPtr<Node> insertNewDefaultParagraphElementAt(const Position&);

+ PassRefPtrWillBeRawPtr<Element> insertNewDefaultParagraphElementAt(const Position&);

- PassRefPtrWillBeRawPtr<Node> moveParagraphContentsToNewBlockIfNecessary(const Position&);

+ PassRefPtrWillBeRawPtr<Element> moveParagraphContentsToNewBlockIfNecessary(const Position&);

void pushAnchorElementDown(Node*);