Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: Source/core/editing/CompositeEditCommand.h

Issue 307243004: Avoid calling slower Node::firstChild() / Node::lastChild() when possible (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/editing/ApplyStyleCommand.cpp ('k') | Source/core/editing/CompositeEditCommand.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2005, 2006, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2005, 2006, 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
139 139
140 void deleteInsignificantText(PassRefPtrWillBeRawPtr<Text>, unsigned start, u nsigned end); 140 void deleteInsignificantText(PassRefPtrWillBeRawPtr<Text>, unsigned start, u nsigned end);
141 void deleteInsignificantText(const Position& start, const Position& end); 141 void deleteInsignificantText(const Position& start, const Position& end);
142 void deleteInsignificantTextDownstream(const Position&); 142 void deleteInsignificantTextDownstream(const Position&);
143 143
144 PassRefPtrWillBeRawPtr<Node> appendBlockPlaceholder(PassRefPtrWillBeRawPtr<E lement>); 144 PassRefPtrWillBeRawPtr<Node> appendBlockPlaceholder(PassRefPtrWillBeRawPtr<E lement>);
145 PassRefPtrWillBeRawPtr<Node> insertBlockPlaceholder(const Position&); 145 PassRefPtrWillBeRawPtr<Node> insertBlockPlaceholder(const Position&);
146 PassRefPtrWillBeRawPtr<Node> addBlockPlaceholderIfNeeded(Element*); 146 PassRefPtrWillBeRawPtr<Node> addBlockPlaceholderIfNeeded(Element*);
147 void removePlaceholderAt(const Position&); 147 void removePlaceholderAt(const Position&);
148 148
149 PassRefPtrWillBeRawPtr<Node> insertNewDefaultParagraphElementAt(const Positi on&); 149 PassRefPtrWillBeRawPtr<Element> insertNewDefaultParagraphElementAt(const Pos ition&);
150 150
151 PassRefPtrWillBeRawPtr<Node> moveParagraphContentsToNewBlockIfNecessary(cons t Position&); 151 PassRefPtrWillBeRawPtr<Element> moveParagraphContentsToNewBlockIfNecessary(c onst Position&);
152 152
153 void pushAnchorElementDown(Node*); 153 void pushAnchorElementDown(Node*);
154 154
155 // FIXME: preserveSelection and preserveStyle should be enums 155 // FIXME: preserveSelection and preserveStyle should be enums
156 void moveParagraph(const VisiblePosition&, const VisiblePosition&, const Vis iblePosition&, bool preserveSelection = false, bool preserveStyle = true, Node* constrainingAncestor = 0); 156 void moveParagraph(const VisiblePosition&, const VisiblePosition&, const Vis iblePosition&, bool preserveSelection = false, bool preserveStyle = true, Node* constrainingAncestor = 0);
157 void moveParagraphs(const VisiblePosition&, const VisiblePosition&, const Vi siblePosition&, bool preserveSelection = false, bool preserveStyle = true, Node* constrainingAncestor = 0); 157 void moveParagraphs(const VisiblePosition&, const VisiblePosition&, const Vi siblePosition&, bool preserveSelection = false, bool preserveStyle = true, Node* constrainingAncestor = 0);
158 void moveParagraphWithClones(const VisiblePosition& startOfParagraphToMove, const VisiblePosition& endOfParagraphToMove, Element* blockElement, Node* outerN ode); 158 void moveParagraphWithClones(const VisiblePosition& startOfParagraphToMove, const VisiblePosition& endOfParagraphToMove, Element* blockElement, Node* outerN ode);
159 void cloneParagraphUnderNewElement(const Position& start, const Position& en d, Node* outerNode, Element* blockElement); 159 void cloneParagraphUnderNewElement(const Position& start, const Position& en d, Node* outerNode, Element* blockElement);
160 void cleanupAfterDeletion(VisiblePosition destination = VisiblePosition()); 160 void cleanupAfterDeletion(VisiblePosition destination = VisiblePosition());
161 161
(...skipping 10 matching lines...) Expand all
172 virtual bool isCompositeEditCommand() const OVERRIDE FINAL { return true; } 172 virtual bool isCompositeEditCommand() const OVERRIDE FINAL { return true; }
173 173
174 RefPtrWillBeMember<EditCommandComposition> m_composition; 174 RefPtrWillBeMember<EditCommandComposition> m_composition;
175 }; 175 };
176 176
177 DEFINE_TYPE_CASTS(CompositeEditCommand, EditCommand, command, command->isComposi teEditCommand(), command.isCompositeEditCommand()); 177 DEFINE_TYPE_CASTS(CompositeEditCommand, EditCommand, command, command->isComposi teEditCommand(), command.isCompositeEditCommand());
178 178
179 } // namespace WebCore 179 } // namespace WebCore
180 180
181 #endif // CompositeEditCommand_h 181 #endif // CompositeEditCommand_h
OLDNEW
« no previous file with comments | « Source/core/editing/ApplyStyleCommand.cpp ('k') | Source/core/editing/CompositeEditCommand.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698