Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 307063003: Revert 273745 "Implements RTP header dumping." due to memory leak (Closed)

Created:
6 years, 6 months ago by battre
Modified:
6 years, 6 months ago
Reviewers:
jiayl
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 273745 "Implements RTP header dumping." due to memory leak See crbug.com/363459 for details. TBR=jiayl@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273767

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -2617 lines) Patch
M trunk/src/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc View 4 chunks +7 lines, -31 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_apitest.cc View 1 chunk +0 lines, -35 lines 0 comments Download
D trunk/src/chrome/browser/media/rtp_dump_type.h View 1 chunk +0 lines, -12 lines 0 comments Download
M trunk/src/chrome/browser/media/webrtc_log_uploader.h View 2 chunks +4 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/media/webrtc_log_uploader.cc View 5 chunks +14 lines, -51 lines 0 comments Download
M trunk/src/chrome/browser/media/webrtc_log_uploader_unittest.cc View 6 chunks +17 lines, -89 lines 0 comments Download
M trunk/src/chrome/browser/media/webrtc_logging_handler_host.h View 6 chunks +18 lines, -51 lines 0 comments Download
M trunk/src/chrome/browser/media/webrtc_logging_handler_host.cc View 9 chunks +16 lines, -151 lines 0 comments Download
D trunk/src/chrome/browser/media/webrtc_rtp_dump_handler.h View 1 chunk +0 lines, -131 lines 0 comments Download
D trunk/src/chrome/browser/media/webrtc_rtp_dump_handler.cc View 1 chunk +0 lines, -342 lines 0 comments Download
D trunk/src/chrome/browser/media/webrtc_rtp_dump_handler_unittest.cc View 1 chunk +0 lines, -393 lines 0 comments Download
D trunk/src/chrome/browser/media/webrtc_rtp_dump_writer.h View 1 chunk +0 lines, -135 lines 0 comments Download
D trunk/src/chrome/browser/media/webrtc_rtp_dump_writer.cc View 1 chunk +0 lines, -447 lines 0 comments Download
D trunk/src/chrome/browser/media/webrtc_rtp_dump_writer_unittest.cc View 1 chunk +0 lines, -362 lines 0 comments Download
M trunk/src/chrome/browser/resources/hangout_services/thunk.js View 3 chunks +3 lines, -28 lines 0 comments Download
M trunk/src/chrome/chrome_browser.gypi View 2 chunks +0 lines, -8 lines 0 comments Download
M trunk/src/chrome/chrome_tests_unit.gypi View 2 chunks +0 lines, -4 lines 0 comments Download
M trunk/src/content/browser/renderer_host/p2p/socket_dispatcher_host.h View 4 chunks +0 lines, -16 lines 0 comments Download
M trunk/src/content/browser/renderer_host/p2p/socket_dispatcher_host.cc View 4 chunks +1 line, -59 lines 0 comments Download
M trunk/src/content/browser/renderer_host/p2p/socket_host.h View 6 chunks +3 lines, -27 lines 0 comments Download
M trunk/src/content/browser/renderer_host/p2p/socket_host.cc View 9 chunks +18 lines, -124 lines 0 comments Download
M trunk/src/content/browser/renderer_host/p2p/socket_host_tcp.h View 3 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/content/browser/renderer_host/p2p/socket_host_tcp.cc View 5 chunks +10 lines, -21 lines 0 comments Download
M trunk/src/content/browser/renderer_host/p2p/socket_host_tcp_server.h View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/content/browser/renderer_host/p2p/socket_host_tcp_server.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M trunk/src/content/browser/renderer_host/p2p/socket_host_tcp_server_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/content/browser/renderer_host/p2p/socket_host_tcp_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/src/content/browser/renderer_host/p2p/socket_host_udp.h View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/content/browser/renderer_host/p2p/socket_host_udp.cc View 3 chunks +5 lines, -11 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_process_host_impl.h View 3 chunks +0 lines, -11 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +2 lines, -27 lines 0 comments Download
M trunk/src/content/public/browser/render_process_host.h View 1 chunk +0 lines, -15 lines 0 comments Download
M trunk/src/content/public/test/mock_render_process_host.h View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/content/public/test/mock_render_process_host.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
battre
6 years, 6 months ago (2014-05-30 08:17:58 UTC) #1
battre
6 years, 6 months ago (2014-05-30 08:18:39 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r273767.

Powered by Google App Engine
This is Rietveld 408576698