Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1069)

Unified Diff: trunk/src/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_apitest.cc

Issue 307063003: Revert 273745 "Implements RTP header dumping." due to memory leak (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_apitest.cc
===================================================================
--- trunk/src/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_apitest.cc (revision 273764)
+++ trunk/src/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_apitest.cc (working copy)
@@ -276,38 +276,3 @@
g_browser_process->webrtc_log_uploader()->OverrideUploadWithBufferForTesting(
NULL);
}
-
-IN_PROC_BROWSER_TEST_F(WebrtcLoggingPrivateApiTest, TestStartStopRtpDump) {
- scoped_refptr<Extension> empty_extension(utils::CreateEmptyExtension());
-
- // Start RTP dump.
- scoped_refptr<extensions::WebrtcLoggingPrivateStartRtpDumpFunction>
- start_function(
- new extensions::WebrtcLoggingPrivateStartRtpDumpFunction());
- start_function->set_extension(empty_extension.get());
- start_function->set_has_callback(true);
-
- content::WebContents* contents =
- browser()->tab_strip_model()->GetActiveWebContents();
- base::ListValue parameters;
- parameters.AppendInteger(extensions::ExtensionTabUtil::GetTabId(contents));
- parameters.AppendString(contents->GetURL().GetOrigin().spec());
- parameters.AppendBoolean(true);
- parameters.AppendBoolean(true);
- std::string parameter_string;
- base::JSONWriter::Write(&parameters, &parameter_string);
-
- scoped_ptr<base::Value> result(utils::RunFunctionAndReturnSingleResult(
- start_function.get(), parameter_string, browser()));
- ASSERT_FALSE(result.get());
-
- // Stop RTP dump.
- scoped_refptr<extensions::WebrtcLoggingPrivateStopRtpDumpFunction>
- stop_function(new extensions::WebrtcLoggingPrivateStopRtpDumpFunction());
- stop_function->set_extension(empty_extension.get());
- stop_function->set_has_callback(true);
-
- result.reset(utils::RunFunctionAndReturnSingleResult(
- stop_function.get(), parameter_string, browser()));
- ASSERT_FALSE(result.get());
-}

Powered by Google App Engine
This is Rietveld 408576698