ServiceWorker: Add a Response ctor that accepts the body as a Blob

ServiceWorker: Add a Response ctor that accepts the body as a Blob

This ctor is expected to be added to the spec:
https://github.com/slightlyoff/ServiceWorker/issues/192

Eventually we'll also have ctors for String, Stream, and
ArrayBuffer bodies.

Multi-sided patch to implement blob-type fetch event
response bodies:
#1: blink-side, THIS PATCH
#2: chromium-side: https://codereview.chromium.org/304153015/
#3: blink-side: https://codereview.chromium.org/304233017

BUG=379074
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175350

[kinuko, 2014-05-30 12:53:14]

DBC

https://codereview.chromium.org/307063002/diff/40001/Source/modules/servicewo...
File Source/modules/serviceworkers/Response.h (right):

https://codereview.chromium.org/307063002/diff/40001/Source/modules/servicewo...
Source/modules/serviceworkers/Response.h:39: String m_blobUUID;
I think this should hold a reference to Blob (or, rather, to BlobDataHandle),
otherwise this uuid could become invalid before we dereference it?

[michaeln1, 2014-05-30 20:09:35]

https://codereview.chromium.org/307063002/diff/40001/Source/modules/servicewo...
File Source/modules/serviceworkers/Response.h (right):

https://codereview.chromium.org/307063002/diff/40001/Source/modules/servicewo...
Source/modules/serviceworkers/Response.h:39: String m_blobUUID;
On 2014/05/30 12:53:15, kinuko (ooo) wrote:
> I think this should hold a reference to Blob (or, rather, to BlobDataHandle),
> otherwise this uuid could become invalid before we dereference it?

yup, the ctor probably should take as input a ptr to the BDH

https://codereview.chromium.org/307063002/diff/40001/Source/platform/exported...
File Source/platform/exported/WebServiceWorkerResponse.cpp (right):

https://codereview.chromium.org/307063002/diff/40001/Source/platform/exported...
Source/platform/exported/WebServiceWorkerResponse.cpp:15: WebString blobUUID;
similary, this probably should be a RefPtr<BDH>

https://codereview.chromium.org/307063002/diff/40001/public/platform/WebServi...
File public/platform/WebServiceWorkerResponse.h (right):

https://codereview.chromium.org/307063002/diff/40001/public/platform/WebServi...
public/platform/WebServiceWorkerResponse.h:57: void setBlobUUID(const
WebString&);
maybe put a setBlobDataHandle(xxx) setter in the INSIDE_BLINK block and leave
the UUID setter out until we need to construct these from withing chromium

additionally, if we have already have use case for calling this setter from
inside chromium, include all the params required to cons up a BDH:
uuid, type, size.

    // For deserialization of script values and ipc messages.
    static PassRefPtr<BlobDataHandle> create(const String& uuid, const String&
type, long long size)
    {
        return adoptRef(new BlobDataHandle(uuid, type, size));
    }

[dominicc (has gone to gerrit), 2014-06-02 00:50:46]

https://codereview.chromium.org/307063002/diff/40001/Source/modules/servicewo...
File Source/modules/serviceworkers/Response.cpp (right):

https://codereview.chromium.org/307063002/diff/40001/Source/modules/servicewo...
Source/modules/serviceworkers/Response.cpp:24: // FIXME: Maybe append or
override content-length and content-type headers using the blob. The spec will
clarify what to do.
Include a link to a specific issue if possible so it is easy for someone to tell
whether the FIXME has become fixable.

[falken, 2014-06-02 03:55:27]

Thanks! PTAL

https://codereview.chromium.org/307063002/diff/40001/Source/modules/servicewo...
File Source/modules/serviceworkers/Response.cpp (right):

https://codereview.chromium.org/307063002/diff/40001/Source/modules/servicewo...
Source/modules/serviceworkers/Response.cpp:24: // FIXME: Maybe append or
override content-length and content-type headers using the blob. The spec will
clarify what to do.
On 2014/06/02 00:50:47, dominicc wrote:
> Include a link to a specific issue if possible so it is easy for someone to
tell
> whether the FIXME has become fixable.

Done.

https://codereview.chromium.org/307063002/diff/40001/Source/modules/servicewo...
File Source/modules/serviceworkers/Response.h (right):

https://codereview.chromium.org/307063002/diff/40001/Source/modules/servicewo...
Source/modules/serviceworkers/Response.h:39: String m_blobUUID;
On 2014/05/30 20:09:35, michaeln1 wrote:
> On 2014/05/30 12:53:15, kinuko (ooo) wrote:
> > I think this should hold a reference to Blob (or, rather, to
BlobDataHandle),
> > otherwise this uuid could become invalid before we dereference it?
> 
> yup, the ctor probably should take as input a ptr to the BDH

I see! Done.

https://codereview.chromium.org/307063002/diff/40001/Source/platform/exported...
File Source/platform/exported/WebServiceWorkerResponse.cpp (right):

https://codereview.chromium.org/307063002/diff/40001/Source/platform/exported...
Source/platform/exported/WebServiceWorkerResponse.cpp:15: WebString blobUUID;
On 2014/05/30 20:09:35, michaeln1 wrote:
> similary, this probably should be a RefPtr<BDH>

Done.

[michaeln, 2014-06-02 23:23:35]

lgtm

[falken, 2014-06-03 00:02:12]

The CQ bit was checked by falken@chromium.org

[commit-bot: I haz the power, 2014-06-03 00:02:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/falken@chromium.org/307063002/60001

[commit-bot: I haz the power, 2014-06-03 00:17:18]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/6733)

[commit-bot: I haz the power, 2014-06-03 00:32:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-03 00:32:15]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/6735)

[falken, 2014-06-03 00:36:56]

Kent-san, can you please review as platform OWNER?

[tkent, 2014-06-03 02:13:40]

https://codereview.chromium.org/307063002/diff/60001/Source/modules/servicewo...
File Source/modules/serviceworkers/Response.cpp (right):

https://codereview.chromium.org/307063002/diff/60001/Source/modules/servicewo...
Source/modules/serviceworkers/Response.cpp:26: return adoptRef(new
Response(body->blobDataHandle(), ResponseInit(responseInit)));
This will crash if |body| is null.

[falken, 2014-06-03 08:12:27]

PTAL

https://codereview.chromium.org/307063002/diff/60001/Source/modules/servicewo...
File Source/modules/serviceworkers/Response.cpp (right):

https://codereview.chromium.org/307063002/diff/60001/Source/modules/servicewo...
Source/modules/serviceworkers/Response.cpp:26: return adoptRef(new
Response(body->blobDataHandle(), ResponseInit(responseInit)));
On 2014/06/03 02:13:41, tkent wrote:
> This will crash if |body| is null.

Great point. Done. I also added a test for it in the third patch
(https://codereview.chromium.org/304233017/)

[tkent, 2014-06-03 08:13:33]

lgtm

[falken, 2014-06-03 08:15:15]

The CQ bit was checked by falken@chromium.org

[commit-bot: I haz the power, 2014-06-03 08:15:39]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/falken@chromium.org/307063002/80001

[commit-bot: I haz the power, 2014-06-03 09:25:09]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/10013)

[commit-bot: I haz the power, 2014-06-03 10:23:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-03 10:23:44]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/10027)

[falken, 2014-06-03 10:26:04]

The CQ bit was checked by falken@chromium.org

[commit-bot: I haz the power, 2014-06-03 10:26:52]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/falken@chromium.org/307063002/80001

[commit-bot: I haz the power, 2014-06-03 11:14:55]

Change committed as 175350