Issue 307013004: Renamed enum constants per Chrome coding guide

Issue 307013004: Renamed enum constants per Chrome coding guide (Closed)

Created:
6 years, 6 months ago by yefimt

Modified:
6 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews, tim+watch_chromium.org, extensions-reviews_chromium.org, tfarina, haitaol+watch_chromium.org, browser-components-watch_chromium.org, chromium-apps-reviews_chromium.org, maniscalco+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Renamed enum constants per Chrome coding guide BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274007

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -36 lines)			Patch
M	chrome/browser/bookmarks/enhanced_bookmarks_features.h	View	1	1 chunk	+8 lines, -8 lines	0 comments	Download
M	chrome/browser/bookmarks/enhanced_bookmarks_features.cc	View	1	4 chunks	+27 lines, -22 lines	0 comments	Download
M	chrome/browser/extensions/external_component_loader.cc	View		1 chunk	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM https://codereview.chromium.org/307013004/diff/1/chrome/browser/bookmarks/enhanced_bookmarks_features.h File chrome/browser/bookmarks/enhanced_bookmarks_features.h (right): https://codereview.chromium.org/307013004/diff/1/chrome/browser/bookmarks/enhanced_bookmarks_features.h#newcode18 chrome/browser/bookmarks/enhanced_bookmarks_features.h:18: NO_BOOKMARKS_EXPERIMENT, BOOKMARKS_EXPERIMENT_NONE (style guide for content recommends this ...

6 years, 6 months ago (2014-05-30 20:23:51 UTC) #2

yefimt

https://codereview.chromium.org/307013004/diff/1/chrome/browser/bookmarks/enhanced_bookmarks_features.h File chrome/browser/bookmarks/enhanced_bookmarks_features.h (right): https://codereview.chromium.org/307013004/diff/1/chrome/browser/bookmarks/enhanced_bookmarks_features.h#newcode18 chrome/browser/bookmarks/enhanced_bookmarks_features.h:18: NO_BOOKMARKS_EXPERIMENT, On 2014/05/30 20:23:52, sky wrote: > BOOKMARKS_EXPERIMENT_NONE (style ...

6 years, 6 months ago (2014-05-30 20:42:37 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yefim@chromium.org/307013004/20001

6 years, 6 months ago (2014-05-30 20:44:07 UTC) #5

Message was sent while issue was closed.

Change committed as 274007

Expand Messages | Collapse Messages