Renamed enum constants per Chrome coding guide

chrome/browser/bookmarks/enhanced_bookmarks_features.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/bookmarks/enhanced_bookmarks_features.h"
 
 #include "base/command_line.h"
 #include "base/metrics/histogram.h"
 #include "base/prefs/pref_service.h"
 #include "base/prefs/scoped_user_pref_update.h"
@@ skipping 24 matching lines @@
   return feature && feature->IsIdInWhitelist(ext_id);
 }
 
 };  // namespace
 
 bool GetBookmarksExperimentExtensionID(const PrefService* user_prefs,
                                        std::string* extension_id) {
   BookmarksExperimentState bookmarks_experiment_state =
       static_cast<BookmarksExperimentState>(user_prefs->GetInteger(
           sync_driver::prefs::kEnhancedBookmarksExperimentEnabled));
-  if (bookmarks_experiment_state == kBookmarksExperimentEnabledFromFinch) {
+  if (bookmarks_experiment_state == BOOKMARKS_EXPERIMENT_ENABLED_FROM_FINCH) {
     *extension_id = GetEnhancedBookmarksExtensionIdFromFinch();
     return !extension_id->empty();
   }
-  if (bookmarks_experiment_state == kBookmarksExperimentEnabled) {
+  if (bookmarks_experiment_state == BOOKMARKS_EXPERIMENT_ENABLED) {
     *extension_id = user_prefs->GetString(
         sync_driver::prefs::kEnhancedBookmarksExtensionId);
     return !extension_id->empty();
   }
 
   return false;
 }
 
 void UpdateBookmarksExperimentState(
     PrefService* user_prefs,
     PrefService* local_state,
     bool user_signed_in,
     BookmarksExperimentState experiment_enabled_from_sync) {
  PrefService* flags_storage = local_state;
 #if defined(OS_CHROMEOS)
   // Chrome OS is using user prefs for flags storage.
   flags_storage = user_prefs;
 #endif
 
   BookmarksExperimentState bookmarks_experiment_state_before =
       static_cast<BookmarksExperimentState>(user_prefs->GetInteger(
           sync_driver::prefs::kEnhancedBookmarksExperimentEnabled));
   // If user signed out, clear possible previous state.
   if (!user_signed_in) {
-    bookmarks_experiment_state_before = kNoBookmarksExperiment;
-    ForceFinchBookmarkExperimentIfNeeded(flags_storage, kNoBookmarksExperiment);
+    bookmarks_experiment_state_before = BOOKMARKS_EXPERIMENT_NONE;
+    ForceFinchBookmarkExperimentIfNeeded(flags_storage,
+        BOOKMARKS_EXPERIMENT_NONE);
   }
 
   // kEnhancedBookmarksExperiment flag could have values "", "1" and "0".
   // "0" - user opted out.
   bool opt_out = CommandLine::ForCurrentProcess()->GetSwitchValueASCII(
                      switches::kEnhancedBookmarksExperiment) == "0";
 
   BookmarksExperimentState bookmarks_experiment_new_state =
-      kNoBookmarksExperiment;
+      BOOKMARKS_EXPERIMENT_NONE;
 
   if (IsEnhancedBookmarksExperimentEnabledFromFinch() && !user_signed_in) {
     if (opt_out) {
       // Experiment enabled but user opted out.
-      bookmarks_experiment_new_state = kBookmarksExperimentOptOutFromFinch;
+      bookmarks_experiment_new_state = BOOKMARKS_EXPERIMENT_OPT_OUT_FROM_FINCH;
     } else {
       // Experiment enabled.
-      bookmarks_experiment_new_state = kBookmarksExperimentEnabledFromFinch;
+      bookmarks_experiment_new_state = BOOKMARKS_EXPERIMENT_ENABLED_FROM_FINCH;
     }
-  } else if (experiment_enabled_from_sync == kBookmarksExperimentEnabled) {
+  } else if (experiment_enabled_from_sync == BOOKMARKS_EXPERIMENT_ENABLED) {
     // Experiment enabled from Chrome sync.
     if (opt_out) {
       // Experiment enabled but user opted out.
-      bookmarks_experiment_new_state = kBookmarksExperimentEnabledUserOptOut;
+      bookmarks_experiment_new_state =
+          BOOKMARKS_EXPERIMENT_ENABLED_USER_OPT_OUT;
     } else {
       // Experiment enabled.
-      bookmarks_experiment_new_state = kBookmarksExperimentEnabled;
+      bookmarks_experiment_new_state = BOOKMARKS_EXPERIMENT_ENABLED;
     }
-  } else if (experiment_enabled_from_sync == kNoBookmarksExperiment) {
+  } else if (experiment_enabled_from_sync == BOOKMARKS_EXPERIMENT_NONE) {
     // Experiment is not enabled from Chrome sync.
-    bookmarks_experiment_new_state = kNoBookmarksExperiment;
-  } else if (bookmarks_experiment_state_before == kBookmarksExperimentEnabled) {
+    bookmarks_experiment_new_state = BOOKMARKS_EXPERIMENT_NONE;
+  } else if (bookmarks_experiment_state_before ==
+             BOOKMARKS_EXPERIMENT_ENABLED) {
     if (opt_out) {
       // Experiment enabled but user opted out.
-      bookmarks_experiment_new_state = kBookmarksExperimentEnabledUserOptOut;
+      bookmarks_experiment_new_state =
+          BOOKMARKS_EXPERIMENT_ENABLED_USER_OPT_OUT;
     } else {
-      bookmarks_experiment_new_state = kBookmarksExperimentEnabled;
+      bookmarks_experiment_new_state = BOOKMARKS_EXPERIMENT_ENABLED;
     }
   } else if (bookmarks_experiment_state_before ==
-             kBookmarksExperimentEnabledUserOptOut) {
+             BOOKMARKS_EXPERIMENT_ENABLED_USER_OPT_OUT) {
     if (opt_out) {
-      bookmarks_experiment_new_state = kBookmarksExperimentEnabledUserOptOut;
+      bookmarks_experiment_new_state =
+          BOOKMARKS_EXPERIMENT_ENABLED_USER_OPT_OUT;
     } else {
       // User opted in again.
-      bookmarks_experiment_new_state = kBookmarksExperimentEnabled;
+      bookmarks_experiment_new_state = BOOKMARKS_EXPERIMENT_ENABLED;
     }
   }
 
   UMA_HISTOGRAM_ENUMERATION("EnhancedBookmarks.SyncExperimentState",
                             bookmarks_experiment_new_state,
-                            kBookmarksExperimentEnumSize);
+                            BOOKMARKS_EXPERIMENT_ENUM_SIZE);
   user_prefs->SetInteger(
       sync_driver::prefs::kEnhancedBookmarksExperimentEnabled,
       bookmarks_experiment_new_state);
   ForceFinchBookmarkExperimentIfNeeded(flags_storage,
                                        bookmarks_experiment_new_state);
 }
 
 void ForceFinchBookmarkExperimentIfNeeded(
     PrefService* flags_storage,
     BookmarksExperimentState bookmarks_experiment_state) {
   if (!flags_storage)
     return;
   ListPrefUpdate update(flags_storage, prefs::kEnabledLabsExperiments);
   base::ListValue* experiments_list = update.Get();
   if (!experiments_list)
     return;
   size_t index;
-  if (bookmarks_experiment_state == kNoBookmarksExperiment) {
+  if (bookmarks_experiment_state == BOOKMARKS_EXPERIMENT_NONE) {
     experiments_list->Remove(
         base::StringValue(switches::kManualEnhancedBookmarks), &index);
     experiments_list->Remove(
         base::StringValue(switches::kManualEnhancedBookmarksOptout), &index);
-  } else if (bookmarks_experiment_state == kBookmarksExperimentEnabled) {
+  } else if (bookmarks_experiment_state == BOOKMARKS_EXPERIMENT_ENABLED) {
     experiments_list->Remove(
         base::StringValue(switches::kManualEnhancedBookmarksOptout), &index);
     experiments_list->AppendIfNotPresent(
         new base::StringValue(switches::kManualEnhancedBookmarks));
   } else if (bookmarks_experiment_state ==
-                 kBookmarksExperimentEnabledUserOptOut) {
+                 BOOKMARKS_EXPERIMENT_ENABLED_USER_OPT_OUT) {
     experiments_list->Remove(
         base::StringValue(switches::kManualEnhancedBookmarks), &index);
     experiments_list->AppendIfNotPresent(
         new base::StringValue(switches::kManualEnhancedBookmarksOptout));
   }
 }
 
 bool IsEnhancedBookmarksExperimentEnabled() {
   CommandLine* command_line = CommandLine::ForCurrentProcess();
   if (command_line->HasSwitch(switches::kManualEnhancedBookmarks) ||
@@ skipping 20 matching lines @@
   if (CommandLine::ForCurrentProcess()->
       HasSwitch(switches::kEnableSyncArticles)) {
     return true;
   }
   if (chrome_variations::GetVariationParamValue(
           kFieldTrialName, "enable-sync-articles") == "1")
     return true;
 
   return false;
 }