Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 306973002: [NaCl SDK] rename nacl_io demo. (Closed)

Created:
6 years, 6 months ago by Sam Clegg
Modified:
6 years, 6 months ago
Reviewers:
binji
CC:
chromium-reviews, binji+watch_chromium.org, native-client-reviews_googlegroups.com
Visibility:
Public.

Description

[NaCl SDK] rename nacl_io demo. Having a library and an example both called nacl_io was confusing some tools (and some people). R=binji@chromium.org, binji Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273881

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2450 lines) Patch
M native_client_sdk/doc_generated/devguide/coding/nacl_io.html View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M native_client_sdk/doc_generated/devguide/devcycle/building.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/build_tools/sdk_files.list View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/doc/devguide/coding/nacl_io.rst View 2 chunks +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/doc/devguide/devcycle/building.rst View 1 chunk +1 line, -1 line 0 comments Download
D native_client_sdk/src/examples/demo/nacl_io/example.dsc View 1 chunk +0 lines, -32 lines 0 comments Download
D native_client_sdk/src/examples/demo/nacl_io/example.js View 1 chunk +0 lines, -349 lines 0 comments Download
D native_client_sdk/src/examples/demo/nacl_io/handlers.h View 1 chunk +0 lines, -41 lines 0 comments Download
D native_client_sdk/src/examples/demo/nacl_io/handlers.c View 1 chunk +0 lines, -1114 lines 0 comments Download
D native_client_sdk/src/examples/demo/nacl_io/index.html View 1 chunk +0 lines, -262 lines 0 comments Download
D native_client_sdk/src/examples/demo/nacl_io/nacl_io_demo.h View 1 chunk +0 lines, -25 lines 0 comments Download
D native_client_sdk/src/examples/demo/nacl_io/nacl_io_demo.c View 1 chunk +0 lines, -482 lines 0 comments Download
D native_client_sdk/src/examples/demo/nacl_io/queue.h View 1 chunk +0 lines, -32 lines 0 comments Download
D native_client_sdk/src/examples/demo/nacl_io/queue.c View 1 chunk +0 lines, -112 lines 0 comments Download
A + native_client_sdk/src/examples/demo/nacl_io_demo/example.dsc View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + native_client_sdk/src/examples/demo/nacl_io_demo/example.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/examples/demo/nacl_io_demo/handlers.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/examples/demo/nacl_io_demo/handlers.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/examples/demo/nacl_io_demo/index.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/examples/demo/nacl_io_demo/nacl_io_demo.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/examples/demo/nacl_io_demo/nacl_io_demo.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/examples/demo/nacl_io_demo/queue.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/examples/demo/nacl_io_demo/queue.c View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sam Clegg
6 years, 6 months ago (2014-05-29 21:14:47 UTC) #1
binji
lgtm, make sure to rebuild the docs.
6 years, 6 months ago (2014-05-29 21:37:07 UTC) #2
Sam Clegg
6 years, 6 months ago (2014-05-30 19:02:35 UTC) #3
Message was sent while issue was closed. 
Committed patchset #3 manually as r273881 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698