Issue 306823002: Flip --enable-apps-show-on-first-paint flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 306823002: Flip --enable-apps-show-on-first-paint flag. (Closed)

Created:
6 years, 6 months ago by benwells

Modified:
4 years ago

Reviewers:

CC:
chromium-reviews, tfarina, chromium-apps-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Flip --enable-apps-show-on-first-paint flag. The flag is now --disable-apps-show-on-first-paint. This causes app windows to be shown after the app first paints its window. This removes the flash of white content when showing app windows. BUG=225843

Patch Set 1 #

Patch Set 2 : Tests #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+236 lines, -164 lines)			Patch
M	apps/app_window.h	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download
M	apps/app_window.cc	View	1	5 chunks	+12 lines, -6 lines	0 comments	Download
M	apps/app_window_contents.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	apps/app_window_contents.cc	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download
M	chrome/app/generated_resources.grd	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/about_flags.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/extensions/api/tabs/ash_panel_contents.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/extensions/api/tabs/ash_panel_contents.cc	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/common/chrome_switches.cc	View		3 chunks	+5 lines, -6 lines	0 comments	Download
M	chrome/common/extensions/api/app_current_window_internal.idl	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/extensions/api/app_window.idl	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/renderer/resources/extensions/app_window_custom_bindings.js	View	1	3 chunks	+9 lines, -0 lines	0 comments	Download
M	chrome/test/data/extensions/platform_apps/active_test/test.js	View	1	1 chunk	+10 lines, -3 lines	0 comments	Download
M	chrome/test/data/extensions/platform_apps/leave_fullscreen/main.js	View	1	1 chunk	+28 lines, -26 lines	0 comments	Download
M	chrome/test/data/extensions/platform_apps/pointer_lock/has_permission/window.html	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/test/data/extensions/platform_apps/pointer_lock/has_permission/window.js	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/test/data/extensions/platform_apps/pointer_lock/no_permission/window.html	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/test/data/extensions/platform_apps/pointer_lock/no_permission/window.js	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/test/data/extensions/platform_apps/prevent_leave_fullscreen/main.js	View	1	2 chunks	+40 lines, -37 lines	0 comments	Download
M	chrome/test/data/extensions/platform_apps/prevent_leave_fullscreen_old/main.js	View	1	2 chunks	+40 lines, -37 lines	0 comments	Download
M	chrome/test/data/extensions/platform_apps/reload/main.html	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/test/data/extensions/platform_apps/reload/main.js	View	1	1 chunk	+5 lines, -3 lines	0 comments	Download
M	chrome/test/data/extensions/platform_apps/restore_state/test.js	View	1	2 chunks	+19 lines, -13 lines	0 comments	Download
M	chrome/test/data/extensions/platform_apps/web_view/focus/embedder.html	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
M	chrome/test/data/extensions/platform_apps/web_view/focus/embedder.js	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/test/data/extensions/platform_apps/web_view/navigation/embedder.html	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/test/data/extensions/platform_apps/web_view/navigation/embedder.js	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/test/data/extensions/platform_apps/web_view/newwindow/embedder.html	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/test/data/extensions/platform_apps/web_view/newwindow/embedder.js	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/test/data/extensions/platform_apps/web_view/pointerlock/embedder.html	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/test/data/extensions/platform_apps/web_view/pointerlock/embedder.js	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download