Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: Source/bindings/v8/ExceptionMessages.cpp

Issue 30673002: More informative error messages for non-Transferables. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: More informative error messages for non-Transferables. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/ExceptionMessages.cpp
diff --git a/Source/bindings/v8/ExceptionMessages.cpp b/Source/bindings/v8/ExceptionMessages.cpp
index 905a2fc063e320a2ea5f00aefccedbb26fab5b4c..68bd05e4935e2c4cbd0a7e81b7b7f341fc8b0b9f 100644
--- a/Source/bindings/v8/ExceptionMessages.cpp
+++ b/Source/bindings/v8/ExceptionMessages.cpp
@@ -58,6 +58,11 @@ String ExceptionMessages::failedToDelete(const String& property, const String& t
return "Failed to delete the '" + property + "' property from '" + type + "': " + detail;
}
+String ExceptionMessages::notASequenceType(const String& argument)
+{
+ return argument + " argument is not an array type, nor has indexed properties.";
Mike West 2013/10/22 06:50:40 "not ... nor" sounds strange. I'd still prefer "..
sof 2013/10/22 16:06:56 I changed this to "is neither an array, nor does i
+}
+
String ExceptionMessages::notEnoughArguments(unsigned expected, unsigned provided)
{
return String::number(expected) + " argument" + (expected > 1 ? "s" : "") + " required, but only " + String::number(provided) + " present.";

Powered by Google App Engine
This is Rietveld 408576698