Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Side by Side Diff: Source/bindings/v8/ExceptionMessages.cpp

Issue 30673002: More informative error messages for non-Transferables. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: More informative error messages for non-Transferables. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 String ExceptionMessages::failedToSet(const String& property, const String& type , const String& detail) 51 String ExceptionMessages::failedToSet(const String& property, const String& type , const String& detail)
52 { 52 {
53 return "Failed to set the '" + property + "' property on '" + type + "': " + detail; 53 return "Failed to set the '" + property + "' property on '" + type + "': " + detail;
54 } 54 }
55 55
56 String ExceptionMessages::failedToDelete(const String& property, const String& t ype, const String& detail) 56 String ExceptionMessages::failedToDelete(const String& property, const String& t ype, const String& detail)
57 { 57 {
58 return "Failed to delete the '" + property + "' property from '" + type + "' : " + detail; 58 return "Failed to delete the '" + property + "' property from '" + type + "' : " + detail;
59 } 59 }
60 60
61 String ExceptionMessages::notASequenceType(const String& argument)
62 {
63 return argument + " argument is not an array type, nor has indexed propertie s.";
Mike West 2013/10/22 06:50:40 "not ... nor" sounds strange. I'd still prefer "..
sof 2013/10/22 16:06:56 I changed this to "is neither an array, nor does i
64 }
65
61 String ExceptionMessages::notEnoughArguments(unsigned expected, unsigned provide d) 66 String ExceptionMessages::notEnoughArguments(unsigned expected, unsigned provide d)
62 { 67 {
63 return String::number(expected) + " argument" + (expected > 1 ? "s" : "") + " required, but only " + String::number(provided) + " present."; 68 return String::number(expected) + " argument" + (expected > 1 ? "s" : "") + " required, but only " + String::number(provided) + " present.";
64 } 69 }
65 70
66 } // namespace WebCore 71 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698