Issue 306723002: Make sure that tag profile updates stop after we leave the isolate view.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 306723002: Make sure that tag profile updates stop after we leave the isolate view. (Closed)

Created:
6 years, 6 months ago by turnidge

Modified:
6 years, 6 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org, turnidge, Cutch

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make sure that tag profile updates stop after we leave the isolate view. If we were currently waiting for isolate.updateTagProfile() to complete when leftView() was called, the call to _updateTimer.cancel() comes too late to prevent the next Timer from being created. Now we use a null _updateTimer to indicate that we have left the view.

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	runtime/bin/vmservice/client/lib/src/elements/isolate_view.dart	View		2 chunks	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages