Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Side by Side Diff: runtime/bin/vmservice/client/lib/src/elements/isolate_view.dart

Issue 306723002: Make sure that tag profile updates stop after we leave the isolate view. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library isolate_view_element; 5 library isolate_view_element;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 import 'observatory_element.dart'; 8 import 'observatory_element.dart';
9 import 'package:observatory/app.dart'; 9 import 'package:observatory/app.dart';
10 import 'package:observatory/service.dart'; 10 import 'package:observatory/service.dart';
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 85
86 Future<ServiceObject> eval(String text) { 86 Future<ServiceObject> eval(String text) {
87 return isolate.get( 87 return isolate.get(
88 isolate.rootLib.id + "/eval?expr=${Uri.encodeComponent(text)}"); 88 isolate.rootLib.id + "/eval?expr=${Uri.encodeComponent(text)}");
89 } 89 }
90 90
91 void _updateTagProfile() { 91 void _updateTagProfile() {
92 isolate.updateTagProfile().then((tagProfile) { 92 isolate.updateTagProfile().then((tagProfile) {
93 tagProfileChart.update(tagProfile); 93 tagProfileChart.update(tagProfile);
94 _drawTagProfileChart(); 94 _drawTagProfileChart();
95 // Start the timer again. 95 if (_updateTimer != null) {
96 _updateTimer = new Timer(new Duration(seconds: 1), _updateTagProfile); 96 // Start the timer again.
97 _updateTimer = new Timer(new Duration(seconds: 1), _updateTagProfile);
98 }
97 }); 99 });
98 } 100 }
99 101
100 void enteredView() { 102 void enteredView() {
101 super.enteredView(); 103 super.enteredView();
102 // Start a timer to update the isolate summary once a second. 104 // Start a timer to update the isolate summary once a second.
103 _updateTimer = new Timer(new Duration(seconds: 1), _updateTagProfile); 105 _updateTimer = new Timer(new Duration(seconds: 1), _updateTagProfile);
104 } 106 }
105 107
106 void leftView() { 108 void leftView() {
107 super.leftView(); 109 super.leftView();
108 if (_updateTimer != null) { 110 if (_updateTimer != null) {
109 _updateTimer.cancel(); 111 _updateTimer.cancel();
112 _updateTimer = null;
110 } 113 }
111 } 114 }
112 115
113 void _drawTagProfileChart() { 116 void _drawTagProfileChart() {
114 var element = shadowRoot.querySelector('#tagProfileChart'); 117 var element = shadowRoot.querySelector('#tagProfileChart');
115 if (element != null) { 118 if (element != null) {
116 tagProfileChart.draw(element); 119 tagProfileChart.draw(element);
117 } 120 }
118 } 121 }
119 122
(...skipping 12 matching lines...) Expand all
132 135
133 Future resume(_) { 136 Future resume(_) {
134 return isolate.get("resume").then((result) { 137 return isolate.get("resume").then((result) {
135 // TODO(turnidge): Instead of asserting here, handle errors 138 // TODO(turnidge): Instead of asserting here, handle errors
136 // properly. 139 // properly.
137 assert(result.serviceType == 'Success'); 140 assert(result.serviceType == 'Success');
138 return isolate.reload(); 141 return isolate.reload();
139 }); 142 });
140 } 143 }
141 } 144 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698