Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 306683002: MockQC stops create its own RP and MockOcclusionTracker (Closed)

Created:
6 years, 6 months ago by weiliangc
Modified:
6 years, 6 months ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, danakj, Ian Vollick, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@testocclusiontracking
Visibility:
Public.

Description

MockQC stops create its own RP and MockOcclusionTracker MockQuadCuller used to make its own RenderPass and Occlusion Tracker when nothing is passed in. Now all unittests use MockQC has to create their own RP and OT, and pass pointers to MockQC. This would make MockQC mimick QC behavior. Next CL would use one QuadSink function to replace the hierarchy of QuadSink, QuadCuller, and MockQuadCuller. This CL follows 306683002. BUG=344962 TEST=cc_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277099

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -64 lines) Patch
M cc/layers/heads_up_display_layer_impl_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M cc/layers/nine_patch_layer_impl_unittest.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M cc/layers/picture_image_layer_impl_unittest.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 1 2 2 chunks +6 lines, -2 lines 0 comments Download
M cc/layers/render_surface_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/layers/scrollbar_layer_unittest.cc View 4 chunks +13 lines, -4 lines 0 comments Download
M cc/layers/solid_color_layer_impl_unittest.cc View 1 2 5 chunks +20 lines, -5 lines 0 comments Download
M cc/layers/tiled_layer_impl_unittest.cc View 1 2 7 chunks +26 lines, -7 lines 0 comments Download
M cc/layers/ui_resource_layer_impl_unittest.cc View 1 2 2 chunks +8 lines, -2 lines 0 comments Download
M cc/test/layer_test_common.h View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M cc/test/layer_test_common.cc View 1 2 4 chunks +13 lines, -11 lines 0 comments Download
M cc/test/mock_occlusion_tracker.h View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M cc/test/mock_quad_culler.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M cc/test/mock_quad_culler.cc View 1 2 1 chunk +0 lines, -22 lines 0 comments Download
M cc/trees/layer_tree_host_pixeltest_on_demand_raster.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
weiliangc
Ignore the trybot results for now, I forgot I need to check in previous patch ...
6 years, 6 months ago (2014-05-30 20:26:29 UTC) #1
enne (OOO)
This is all pretty straightforward. lgtm
6 years, 6 months ago (2014-05-30 21:29:30 UTC) #2
weiliangc
The CQ bit was checked by weiliangc@chromium.org
6 years, 6 months ago (2014-06-13 19:53:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/weiliangc@chromium.org/306683002/60001
6 years, 6 months ago (2014-06-13 19:55:14 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-13 22:01:47 UTC) #5
Message was sent while issue was closed.
Change committed as 277099

Powered by Google App Engine
This is Rietveld 408576698