Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 306663002: Check that all properties are processed in NameDictionary::CopyEnumKeysTo. (Closed)

Created:
6 years, 6 months ago by ulan
Modified:
6 years, 6 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Check that all properties are processed in NameDictionary::CopyEnumKeysTo. BUG=372579 LOG=N R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21571

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/objects.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ulan
PTAL. After looking at the crash in the 372579, I have two explanations: - either ...
6 years, 6 months ago (2014-05-28 12:45:18 UTC) #1
Toon Verwaest
lgtm
6 years, 6 months ago (2014-05-28 12:47:33 UTC) #2
ulan
6 years, 6 months ago (2014-05-28 13:36:30 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21571 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698