src/objects.cc - Issue 306663002: Check that all properties are processed in NameDictionary::CopyEnumKeysTo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 306663002: Check that all properties are processed in NameDictionary::CopyEnumKeysTo. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index 19dcf1b1d86766185c28370b5a04d81388c909fd..1fee95b6b9a897615b25bcc36309a0a1206fdf6a 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -16100,6 +16100,7 @@ void NameDictionary::CopyEnumKeysTo(FixedArray* storage) {

if (properties == length) break;

}

+ CHECK_EQ(length, properties);

EnumIndexComparator cmp(this);

Smi** start = reinterpret_cast<Smi**>(storage->GetFirstElementAddress());

std::sort(start, start + length, cmp);

« no previous file with comments | « no previous file | no next file » | no next file with comments »