Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issue 306543008: Qualify include paths in generated bindings (Closed)

Created:
6 years, 6 months ago by Nils Barth (inactive)
Modified:
6 years, 6 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Visibility:
Public.

Description

Qualify include paths in generated bindings Now an easy change, this correctly adds qualified paths based on component. There are still other places to qualify (notably v8/custom), which I'll do separately, so we can't yet remove the other dirs from core.gyp, but we're close! Also some test fixes due to use of invalid interface types, and lotta test updates. R=haraken BUG=358074 BUG=377364 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174968

Patch Set 1 #

Patch Set 2 : r-b-t and tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -69 lines) Patch
M Source/bindings/core/generated.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/modules/generated.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/scripts/code_generator_v8.py View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/bindings/scripts/compute_interfaces_info_individual.py View 1 4 chunks +6 lines, -2 lines 0 comments Download
M Source/bindings/scripts/v8_types.py View 2 chunks +8 lines, -1 line 0 comments Download
M Source/bindings/tests/idls/TestInterface.idl View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/idls/TestInterface2.idl View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/idls/TestTypedefs.idl View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/V8TestCallbackInterface.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterface.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterface.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterface2.cpp View 1 2 chunks +6 lines, -7 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterface3.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor2.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceDocument.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEventConstructor.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEventConstructor.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEventTarget.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceGarbageCollected.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceGarbageCollected.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNode.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNode.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestNode.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 1 1 chunk +20 lines, -19 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperations.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestTypedefs.cpp View 1 5 chunks +11 lines, -13 lines 0 comments Download
M Tools/Scripts/webkitpy/bindings/main.py View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Nils Barth (inactive)
Now just a simple change!
6 years, 6 months ago (2014-05-28 08:16:15 UTC) #1
haraken
LGTM
6 years, 6 months ago (2014-05-28 08:34:56 UTC) #2
Nils Barth (inactive)
Thanks! BTW, just updated with r-b-t updates; will commit once earlier ones land.
6 years, 6 months ago (2014-05-28 08:57:59 UTC) #3
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 6 months ago (2014-05-28 11:54:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/306543008/20001
6 years, 6 months ago (2014-05-28 11:54:57 UTC) #5
Nils Barth (inactive)
The CQ bit was unchecked by nbarth@chromium.org
6 years, 6 months ago (2014-05-28 12:23:46 UTC) #6
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 6 months ago (2014-05-28 12:24:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/306543008/20001
6 years, 6 months ago (2014-05-28 12:24:14 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-05-28 13:10:09 UTC) #9
Message was sent while issue was closed.
Change committed as 174968

Powered by Google App Engine
This is Rietveld 408576698