Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2477)

Unified Diff: Tools/Scripts/webkitpy/bindings/main.py

Issue 306543008: Qualify include paths in generated bindings (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: r-b-t and tests Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/tests/results/V8TestTypedefs.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/Scripts/webkitpy/bindings/main.py
diff --git a/Tools/Scripts/webkitpy/bindings/main.py b/Tools/Scripts/webkitpy/bindings/main.py
index 7a002965edceb966f00f8c54fa9955775ffc78ea..04e11e52affbb19d1de8d725e392d53819c298d1 100644
--- a/Tools/Scripts/webkitpy/bindings/main.py
+++ b/Tools/Scripts/webkitpy/bindings/main.py
@@ -109,8 +109,13 @@ def generate_interface_dependencies():
# the real Node.idl file.
# 2-stage computation: individual, then overall
+ #
+ # Properly should compute separately by component (currently test
+ # includes are invalid), but that's brittle (would need to update this file
+ # for each new component) and doesn't test the code generator any better
+ # than using a single component.
for idl_filename in idl_paths_recursive(source_path):
- compute_info_individual(idl_filename)
+ compute_info_individual(idl_filename, 'tests')
info_individuals = [info_individual()]
compute_interfaces_info_overall(info_individuals)
« no previous file with comments | « Source/bindings/tests/results/V8TestTypedefs.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698