Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 306453005: Replace some calls to MemCopy with small constant sizes with memcpy (Closed)

Created:
6 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 7 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Replace some calls to MemCopy with small constant sizes with memcpy MemCopy is only meant for variable size, large (>64bytes) copies, otherwise, it's probably slower than memcpy due to the call overhead and the compiler can't optimize it away. BUG=none R=jkummerow@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=21519

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -40 lines) Patch
M src/arm/assembler-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/constants-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/simulator-arm.cc View 10 chunks +22 lines, -22 lines 0 comments Download
M src/atomicops_internals_x86_gcc.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M src/conversions-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gdb-jit.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/assembler-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/simulator-mips.cc View 5 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
6 years, 7 months ago (2014-05-27 11:49:32 UTC) #1
Jakob Kummerow
Yeah, using MemCopy for these was kinda stupid. Should be CopyWords, if we wanted to ...
6 years, 7 months ago (2014-05-27 11:54:34 UTC) #2
jochen (gone - plz use gerrit)
6 years, 7 months ago (2014-05-27 12:02:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21519 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698