Issue 306403003: Revert 274322 "Implement a demo that shows one app embedding ren..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 306403003: Revert 274322 "Implement a demo that shows one app embedding ren..." (Closed)

Created:
6 years, 6 months ago by Ben Goodger (Google)

Modified:
6 years, 6 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 274322 "Implement a demo that shows one app embedding ren..." > Implement a demo that shows one app embedding rendering in another. > > launcher inits the view manager, running the "window manager" app @ root. > window manager embeds another app. > > R=sky@chromium.org > TEST=mojo_shell --origin=http://127.0.0.1:4444 --disable-cache mojo:mojo_demo_launcher > http://crbug.com/365012 > > Review URL: https://codereview.chromium.org/303163005 TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274328

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+80 lines, -300 lines)			Patch
D	trunk/src/mojo/examples/demo_launcher/demo_launcher.cc	View	1 chunk	+0 lines, -43 lines	0 comments	Download
D	trunk/src/mojo/examples/embedded_app/embedded_app.cc	View	1 chunk	+0 lines, -40 lines	0 comments	Download
M	trunk/src/mojo/examples/sample_view_manager_app/sample_view_manager_app.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download
D	trunk/src/mojo/examples/window_manager/window_manager.cc	View	1 chunk	+0 lines, -51 lines	0 comments	Download
M	trunk/src/mojo/mojo.gyp	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	trunk/src/mojo/mojo_examples.gypi	View	2 chunks	+3 lines, -46 lines	0 comments	Download
M	trunk/src/mojo/services/public/cpp/view_manager/DEPS	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/mojo/services/public/cpp/view_manager/lib/view.cc	View	2 chunks	+0 lines, -7 lines	0 comments	Download
M	trunk/src/mojo/services/public/cpp/view_manager/lib/view_manager.cc	View	4 chunks	+6 lines, -13 lines	0 comments	Download
M	trunk/src/mojo/services/public/cpp/view_manager/lib/view_manager_private.h	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	trunk/src/mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.h	View	6 chunks	+11 lines, -10 lines	0 comments	Download
M	trunk/src/mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.cc	View	10 chunks	+33 lines, -65 lines	0 comments	Download
M	trunk/src/mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc	View	2 chunks	+9 lines, -5 lines	0 comments	Download
M	trunk/src/mojo/services/public/cpp/view_manager/view.h	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	trunk/src/mojo/services/public/cpp/view_manager/view_manager.h	View	3 chunks	+11 lines, -8 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

6 years, 6 months ago (2014-06-02 21:11:09 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r274328 (tree was closed).

Expand Messages | Collapse Messages