Issue 303163005: Embedding demo in View manager

Issue 303163005: Embedding demo in View manager (Closed)

Created:
6 years, 6 months ago by Ben Goodger (Google)

Modified:
6 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Implement a demo that shows one app embedding rendering in another. launcher inits the view manager, running the "window manager" app @ root. window manager embeds another app. ** not tested by main chrome integration testing ** R=sky@chromium.org TEST=mojo_shell --origin=http://127.0.0.1:4444 --disable-cache mojo:mojo_demo_launcher http://crbug.com/365012 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274322 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274422

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Total comments: 1

Patch Set 7 : . #

Patch Set 8 : . #

Patch Set 9 : . #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+301 lines, -80 lines)			Patch
A	mojo/examples/demo_launcher/demo_launcher.cc	View	1 2 3 4 5 6 7	1 chunk	+43 lines, -0 lines	0 comments	Download
A	mojo/examples/embedded_app/embedded_app.cc	View	1 2 3 4	1 chunk	+40 lines, -0 lines	0 comments	Download
M	mojo/examples/sample_view_manager_app/sample_view_manager_app.cc	View	1 2 3	1 chunk	+1 line, -4 lines	0 comments	Download
A	mojo/examples/window_manager/window_manager.cc	View	1 2 3 4	1 chunk	+51 lines, -0 lines	0 comments	Download
M	mojo/mojo.gyp	View	1 2 3 4 5 6	1 chunk	+3 lines, -1 line	0 comments	Download
M	mojo/mojo_examples.gypi	View	1 2 3	2 chunks	+46 lines, -3 lines	0 comments	Download
M	mojo/mojo_services.gypi	View	1 2 3 4 5 6 7 8	1 chunk	+1 line, -0 lines	0 comments	Download
M	mojo/services/public/cpp/view_manager/DEPS	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	mojo/services/public/cpp/view_manager/lib/view.cc	View	1 2 3	2 chunks	+7 lines, -0 lines	0 comments	Download
M	mojo/services/public/cpp/view_manager/lib/view_manager.cc	View	1 2	4 chunks	+13 lines, -6 lines	0 comments	Download
M	mojo/services/public/cpp/view_manager/lib/view_manager_private.h	View	1 2	1 chunk	+4 lines, -2 lines	0 comments	Download
M	mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.h	View	1 2	6 chunks	+10 lines, -11 lines	0 comments	Download
M	mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.cc	View	1 2	10 chunks	+65 lines, -33 lines	0 comments	Download
M	mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc	View		2 chunks	+5 lines, -9 lines	0 comments	Download
M	mojo/services/public/cpp/view_manager/view.h	View	1 2 3	2 chunks	+3 lines, -0 lines	0 comments	Download
M	mojo/services/public/cpp/view_manager/view_manager.h	View	1 2	3 chunks	+8 lines, -11 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM https://codereview.chromium.org/303163005/diff/90001/mojo/examples/demo_launcher/demo_launcher.cc File mojo/examples/demo_launcher/demo_launcher.cc (right): https://codereview.chromium.org/303163005/diff/90001/mojo/examples/demo_launcher/demo_launcher.cc#newcode27 mojo/examples/demo_launcher/demo_launcher.cc:27: base::RunLoop().Run(); Are you sure you need this?

6 years, 6 months ago (2014-06-02 19:14:58 UTC) #2

Ben Goodger (Google)

Committed patchset #8 manually as r274322 (presubmit successful).

6 years, 6 months ago (2014-06-02 20:55:01 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/303163005/150001

6 years, 6 months ago (2014-06-02 21:43:21 UTC) #5

Ben Goodger (Google)

6 years, 6 months ago (2014-06-03 05:39:05 UTC) #6

Message was sent while issue was closed.

Committed patchset #9 manually as r274422 (tree was closed).

Expand Messages | Collapse Messages