Source/modules/gamepad/NavigatorGamepad.h - Issue 306363002: Gamepad: honor page visibility

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/gamepad/NavigatorGamepad.h

Issue 306363002: Gamepad: honor page visibility (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: just a comment that it will be better with Oilpan Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/gamepad/NavigatorGamepad.h

diff --git a/Source/modules/gamepad/NavigatorGamepad.h b/Source/modules/gamepad/NavigatorGamepad.h

index 15f9cf7a3bb73862130ae8ea347098210f7f2f9c..84646e156fe8503046063d966a94ed95606844d8 100644

--- a/Source/modules/gamepad/NavigatorGamepad.h

+++ b/Source/modules/gamepad/NavigatorGamepad.h

@@ -71,6 +71,7 @@ private:

virtual void willDetachGlobalObjectFromFrame() OVERRIDE;

// DeviceSensorEventController

+ virtual void pageVisibilityChanged() OVERRIDE FINAL;

virtual void registerWithDispatcher() OVERRIDE;

virtual void unregisterWithDispatcher() OVERRIDE;

virtual bool hasLastData() OVERRIDE;

@@ -83,8 +84,14 @@ private:

virtual void didRemoveEventListener(DOMWindow*, const AtomicString&) OVERRIDE;

virtual void didRemoveAllEventListeners(DOMWindow*) OVERRIDE;

+ // Supplement

+ virtual void willBeDestroyed();

+ void invalidateCanContinueDispatchingSentinel();

PersistentWillBeMember<GamepadList> m_gamepads;

PersistentWillBeMember<WebKitGamepadList> m_webkitGamepads;

+ bool* m_canContinueDispatchingSentinelPtr;

};

} // namespace WebCore