Source/core/frame/DeviceSensorEventController.cpp - Issue 306363002: Gamepad: honor page visibility

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/DeviceSensorEventController.cpp

Issue 306363002: Gamepad: honor page visibility (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: just a comment that it will be better with Oilpan Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/frame/DeviceSensorEventController.cpp

diff --git a/Source/core/frame/DeviceSensorEventController.cpp b/Source/core/frame/DeviceSensorEventController.cpp

index 5ffa369be494a6bdd700d4b41f8cc5081b5fb6bf..f128a4e426f102a44111172d5100d285a9a69301 100644

--- a/Source/core/frame/DeviceSensorEventController.cpp

+++ b/Source/core/frame/DeviceSensorEventController.cpp

@@ -101,12 +101,9 @@ void DeviceSensorEventController::stopUpdating()

void DeviceSensorEventController::pageVisibilityChanged()

{

- if (!m_hasEventListener)

- return;

- if (page()->visibilityState() == PageVisibilityStateVisible)

+ if (page()->visibilityState() == PageVisibilityStateVisible && m_hasEventListener)

startUpdating();

- else

+ else if (page()->visibilityState() == PageVisibilityStateHidden)

stopUpdating();

}