Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1274)

Unified Diff: chrome/browser/bookmarks/chrome_bookmark_client.h

Issue 306293006: Introduce ChromeBookmarkClientFactory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@364865
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/bookmarks/chrome_bookmark_client.h
diff --git a/chrome/browser/bookmarks/chrome_bookmark_client.h b/chrome/browser/bookmarks/chrome_bookmark_client.h
index bf079d7e234f6357a993402f6f69aee5a9970c77..9aae0f2134da89b24a5daa41a42a71b036e5aefe 100644
--- a/chrome/browser/bookmarks/chrome_bookmark_client.h
+++ b/chrome/browser/bookmarks/chrome_bookmark_client.h
@@ -17,16 +17,15 @@ class Profile;
class ChromeBookmarkClient : public BookmarkClient,
public content::NotificationObserver,
- public KeyedService,
public BaseBookmarkModelObserver {
- public:
- // |index_urls| says whether URLs should be stored in the BookmarkIndex
- // in addition to bookmark titles.
- ChromeBookmarkClient(Profile* profile, bool index_urls);
+ public:
+ explicit ChromeBookmarkClient(Profile* profile);
virtual ~ChromeBookmarkClient();
- // Returns the BookmarkModel that corresponds to this ChromeBookmarkClient.
- BookmarkModel* model() { return model_.get(); }
+ void Init(BookmarkModel* model);
+
+ // KeyedService:
+ virtual void Shutdown() OVERRIDE;
// BookmarkClient:
virtual bool PreferTouchIcon() OVERRIDE;
@@ -48,9 +47,6 @@ class ChromeBookmarkClient : public BookmarkClient,
const content::NotificationSource& source,
const content::NotificationDetails& details) OVERRIDE;
- // KeyedService:
- virtual void Shutdown() OVERRIDE;
-
private:
// BaseBookmarkModelObserver:
virtual void BookmarkModelChanged() OVERRIDE;
@@ -67,7 +63,7 @@ class ChromeBookmarkClient : public BookmarkClient,
content::NotificationRegistrar registrar_;
- scoped_ptr<BookmarkModel> model_;
+ BookmarkModel* model_;
DISALLOW_COPY_AND_ASSIGN(ChromeBookmarkClient);
};

Powered by Google App Engine
This is Rietveld 408576698