Introduce ChromeBookmarkClientFactory

chrome/browser/bookmarks/bookmark_model_factory.h

Index: chrome/browser/bookmarks/bookmark_model_factory.h
diff --git a/chrome/browser/bookmarks/bookmark_model_factory.h b/chrome/browser/bookmarks/bookmark_model_factory.h
index 87180ced7fd16fab8691ee14ed3d1d8413cabc19..d538e3c47c2a85143ac4bb298c7b2e94edcb3bf7 100644
--- a/chrome/browser/bookmarks/bookmark_model_factory.h
+++ b/chrome/browser/bookmarks/bookmark_model_factory.h
@@ -5,16 +5,16 @@
 #ifndef CHROME_BROWSER_BOOKMARKS_BOOKMARK_MODEL_FACTORY_H_
 #define CHROME_BROWSER_BOOKMARKS_BOOKMARK_MODEL_FACTORY_H_
 
-#include "base/basictypes.h"
-#include "base/compiler_specific.h"
+#include "base/macros.h"
 #include "components/keyed_service/content/browser_context_keyed_service_factory.h"
 
-template <typename T> struct DefaultSingletonTraits;
+template <typename T>

[tfarina, 2014/06/04 16:04:02]

why this change? could you revert it? it puts an unnecessary blame ere.

[sdefresne, 2014/06/04 16:08:48]

This was reformated by clang-format when I ran it over the whole CL. I can
revert it if really required, but I don't think that changing the blame on that
line is a problem.

[tfarina, 2014/06/04 16:14:25]

I know we can go back in time and see who added this line but I think the
obfuscating for the sake of clang-format is not worth it.

The style guide
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Forwar...,
has no examples of how to format it. So it may be that both forms are
acceptable.

You can see in this search:
https://code.google.com/p/chromium/codesearch#search/&q=template%20%3Ctypenam...,
that a single line declaration is very common.

[sdefresne, 2014/06/10 13:12:21]

Done.

+struct DefaultSingletonTraits;
 
-class Profile;
 class BookmarkModel;
+class Profile;
 
-// Singleton that owns all BookmarkModel and associates them with Profiles.
+// Singleton that owns all BookmarkModels and associates them with Profiles.
 class BookmarkModelFactory : public BrowserContextKeyedServiceFactory {
  public:
   static BookmarkModel* GetForProfile(Profile* profile);