chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.mm - Issue 306293006: Introduce ChromeBookmarkClientFactory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.mm

Issue 306293006: Introduce ChromeBookmarkClientFactory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@364865

Patch Set: Add missing dependency in components/policy/policy_browser.gypi Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.mm

index 1baf23fc2b936cb18503184439aef3abd50bed2b..537f99d7c48afc88c4d0b247c66c6820dc5bde7e 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.mm

@@ -9,6 +9,7 @@

#import "chrome/browser/app_controller_mac.h"

#include "chrome/browser/bookmarks/bookmark_model_factory.h"

#include "chrome/browser/bookmarks/chrome_bookmark_client.h"

+#include "chrome/browser/bookmarks/chrome_bookmark_client_factory.h"

#include "chrome/browser/prefs/incognito_mode_prefs.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/profiles/profile_manager.h"

@@ -77,7 +78,7 @@ void BookmarkMenuBridge::UpdateMenuInternal(NSMenu* bookmark_menu,

// Add at most one separator for the bookmark bar and the managed bookmarks

// folder.

ChromeBookmarkClient* client =

- BookmarkModelFactory::GetChromeBookmarkClientForProfile(profile_);

+ ChromeBookmarkClientFactory::GetForProfile(profile_);

const BookmarkNode* barNode = model->bookmark_bar_node();

const BookmarkNode* managedNode = client->managed_node();

if (!barNode->empty() || !managedNode->empty())