chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm - Issue 306293006: Introduce ChromeBookmarkClientFactory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm

Issue 306293006: Introduce ChromeBookmarkClientFactory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@364865

Patch Set: Add missing dependency in components/policy/policy_browser.gypi Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm

index 085206b1ed64530ad3486825816060db3aed1ba0..c30de7d476c1da713addb7838b31953744585dba 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm

@@ -13,6 +13,7 @@

#include "base/strings/sys_string_conversions.h"

#include "chrome/browser/bookmarks/bookmark_model_factory.h"

#include "chrome/browser/bookmarks/chrome_bookmark_client.h"

+#include "chrome/browser/bookmarks/chrome_bookmark_client_factory.h"

#include "chrome/browser/profiles/profile.h"

#import "chrome/browser/ui/cocoa/bookmarks/bookmark_all_tabs_controller.h"

#import "chrome/browser/ui/cocoa/bookmarks/bookmark_editor_controller.h"

@@ -504,7 +505,7 @@ NSString* const kOkEnabledName = @"okEnabled";

- (NSMutableArray*)addChildFoldersFromNode:(const BookmarkNode*)node {

ChromeBookmarkClient* client =

- BookmarkModelFactory::GetChromeBookmarkClientForProfile(profile_);

+ ChromeBookmarkClientFactory::GetForProfile(profile_);

NSMutableArray* childFolders = nil;

int childCount = node->child_count();

for (int i = 0; i < childCount; ++i) {