Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3234)

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.h

Issue 306293006: Introduce ChromeBookmarkClientFactory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@364865
Patch Set: Add missing dependency in components/policy/policy_browser.gypi Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.h
diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.h b/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.h
index 502430f66263e3202698f2b27aff0c681fd96b50..ec515917e4dc9d9edc0adb0fe337807d57590770 100644
--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.h
+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.h
@@ -9,6 +9,7 @@
#import "chrome/browser/ui/cocoa/base_bubble_controller.h"
#import "chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa.h"
+class BookmarkModel;
class BookmarkNode;
class ChromeBookmarkClient;
@class BookmarkBubbleController;
@@ -20,8 +21,10 @@ class ChromeBookmarkClient;
// the bookmark in various ways (name, folder, etc.)
@interface BookmarkBubbleController : BaseBubbleController {
@private
- // Both weak; owned by the current browser's profile.
+ // |client_|, |model_| and |node_| are weak and owned by the current browser's
+ // profile.
ChromeBookmarkClient* client_; // weak
+ BookmarkModel* model_; // weak
const BookmarkNode* node_; // weak
// The bookmark node whose button we asked to pulse.
@@ -51,6 +54,7 @@ class ChromeBookmarkClient;
// init routine. Closing of the window happens implicitly on dealloc.
- (id)initWithParentWindow:(NSWindow*)parentWindow
client:(ChromeBookmarkClient*)client
+ model:(BookmarkModel*)model
node:(const BookmarkNode*)node
alreadyBookmarked:(BOOL)alreadyBookmarked;

Powered by Google App Engine
This is Rietveld 408576698