chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm - Issue 306293006: Introduce ChromeBookmarkClientFactory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm

Issue 306293006: Introduce ChromeBookmarkClientFactory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@364865

Patch Set: Add missing dependency in components/policy/policy_browser.gypi Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm

index 8f0154b0a53911c672638f96c1e6a327e8a4bf11..ac68345c0a48a48a7de8751c3a152002f727378e 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm

@@ -9,6 +9,7 @@

#include "base/strings/sys_string_conversions.h"

#import "chrome/browser/bookmarks/bookmark_model_factory.h"

#import "chrome/browser/bookmarks/chrome_bookmark_client.h"

+#import "chrome/browser/bookmarks/chrome_bookmark_client_factory.h"

#import "chrome/browser/profiles/profile.h"

#import "chrome/browser/ui/cocoa/bookmarks/bookmark_bar_constants.h"

#import "chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h"

@@ -1260,7 +1261,7 @@ static BOOL ValueInRangeInclusive(CGFloat low, CGFloat value, CGFloat high) {

}

ChromeBookmarkClient* client =

- BookmarkModelFactory::GetChromeBookmarkClientForProfile(profile_);

+ ChromeBookmarkClientFactory::GetForProfile(profile_);

if (!client->CanBeEditedByUser(destParent))

return NO;

if (!client->CanBeEditedByUser(sourceNode))

@@ -1825,7 +1826,7 @@ static BOOL ValueInRangeInclusive(CGFloat low, CGFloat value, CGFloat high) {

}

ChromeBookmarkClient* client =

- BookmarkModelFactory::GetChromeBookmarkClientForProfile(profile_);

+ ChromeBookmarkClientFactory::GetForProfile(profile_);

if (!client->CanBeEditedByUser(destParent))

return NO;