chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc - Issue 306293006: Introduce ChromeBookmarkClientFactory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc

Issue 306293006: Introduce ChromeBookmarkClientFactory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@364865

Patch Set: Add missing dependency in components/policy/policy_browser.gypi Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc

diff --git a/chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc b/chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc

index ec6f436da3c09fb580abc5c9c1693dc93cf671a2..665f6bf1187acb948b6cbc85d56fac32ff9451ac 100644

--- a/chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc

+++ b/chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc

@@ -106,11 +106,11 @@ void AddNodeFoldersOnly(ChromeBookmarkClient* client,

return AddNodeHelper(client, node, nodes, recurse, true);

}

-bool RemoveNode(ChromeBookmarkClient* client,

+bool RemoveNode(BookmarkModel* model,

+ ChromeBookmarkClient* client,

int64 id,

bool recursive,

std::string* error) {

- BookmarkModel* model = client->model();

const BookmarkNode* node = GetBookmarkNodeByID(model, id);

if (!node) {

*error = keys::kNoNodeError;