Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(945)

Side by Side Diff: chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc

Issue 306293006: Introduce ChromeBookmarkClientFactory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@364865
Patch Set: Add missing dependency in components/policy/policy_browser.gypi Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.h" 5 #include "chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.h"
6 6
7 #include <math.h> // For floor() 7 #include <math.h> // For floor()
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/strings/string_number_conversions.h" 10 #include "base/strings/string_number_conversions.h"
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 return AddNodeHelper(client, node, nodes, recurse, false); 99 return AddNodeHelper(client, node, nodes, recurse, false);
100 } 100 }
101 101
102 void AddNodeFoldersOnly(ChromeBookmarkClient* client, 102 void AddNodeFoldersOnly(ChromeBookmarkClient* client,
103 const BookmarkNode* node, 103 const BookmarkNode* node,
104 std::vector<linked_ptr<BookmarkTreeNode> >* nodes, 104 std::vector<linked_ptr<BookmarkTreeNode> >* nodes,
105 bool recurse) { 105 bool recurse) {
106 return AddNodeHelper(client, node, nodes, recurse, true); 106 return AddNodeHelper(client, node, nodes, recurse, true);
107 } 107 }
108 108
109 bool RemoveNode(ChromeBookmarkClient* client, 109 bool RemoveNode(BookmarkModel* model,
110 ChromeBookmarkClient* client,
110 int64 id, 111 int64 id,
111 bool recursive, 112 bool recursive,
112 std::string* error) { 113 std::string* error) {
113 BookmarkModel* model = client->model();
114 const BookmarkNode* node = GetBookmarkNodeByID(model, id); 114 const BookmarkNode* node = GetBookmarkNodeByID(model, id);
115 if (!node) { 115 if (!node) {
116 *error = keys::kNoNodeError; 116 *error = keys::kNoNodeError;
117 return false; 117 return false;
118 } 118 }
119 if (model->is_permanent_node(node)) { 119 if (model->is_permanent_node(node)) {
120 *error = keys::kModifySpecialError; 120 *error = keys::kModifySpecialError;
121 return false; 121 return false;
122 } 122 }
123 if (client->IsDescendantOfManagedNode(node)) { 123 if (client->IsDescendantOfManagedNode(node)) {
124 *error = keys::kModifyManagedError; 124 *error = keys::kModifyManagedError;
125 return false; 125 return false;
126 } 126 }
127 if (node->is_folder() && !node->empty() && !recursive) { 127 if (node->is_folder() && !node->empty() && !recursive) {
128 *error = keys::kFolderNotEmptyError; 128 *error = keys::kFolderNotEmptyError;
129 return false; 129 return false;
130 } 130 }
131 131
132 const BookmarkNode* parent = node->parent(); 132 const BookmarkNode* parent = node->parent();
133 model->Remove(parent, parent->GetIndexOf(node)); 133 model->Remove(parent, parent->GetIndexOf(node));
134 return true; 134 return true;
135 } 135 }
136 136
137 } // namespace bookmark_api_helpers 137 } // namespace bookmark_api_helpers
138 } // namespace extensions 138 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698