Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 306143003: Remove the BookmarkService interface (Closed)

Created:
6 years, 6 months ago by sdefresne
Modified:
6 years, 6 months ago
Reviewers:
gab, Nicolas Zea, sky, blundell
CC:
chromium-reviews, haitaol+watch_chromium.org, tfarina, maniscalco+watch_chromium.org, browser-components-watch_chromium.org, tim+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@371825.2
Visibility:
Public.

Description

Remove the BookmarkService interface The only client of the interface was //chrome/browser/history for the HistoryService but since it now uses a HistoryClient to abstract the access to the bookmarks, the interface is obsolete. BUG=364865 TBR=gab,zea,sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275360

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -73 lines) Patch
M chrome/browser/history/DEPS View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/history/android/bookmark_model_sql_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/profile_writer_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/test/integration/single_client_bookmarks_sync_test.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/bookmarks.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/bookmarks/browser/bookmark_model.h View 1 3 chunks +21 lines, -15 lines 0 comments Download
M components/bookmarks/browser/bookmark_model.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/bookmarks/browser/bookmark_model_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D components/bookmarks/browser/bookmark_service.h View 1 chunk +0 lines, -43 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
sdefresne
PTAL
6 years, 6 months ago (2014-05-30 15:52:07 UTC) #1
blundell
LGTM s/"now uses"/"will use" in the CL description? History hasn't yet abstracted the dependence on ...
6 years, 6 months ago (2014-06-02 09:06:39 UTC) #2
sdefresne
On 2014/06/02 09:06:39, blundell wrote: > LGTM > > s/"now uses"/"will use" in the CL ...
6 years, 6 months ago (2014-06-02 09:59:29 UTC) #3
sdefresne
The CQ bit was checked by sdefresne@chromium.org
6 years, 6 months ago (2014-06-04 15:50:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sdefresne@chromium.org/306143003/20001
6 years, 6 months ago (2014-06-04 15:52:37 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 6 months ago (2014-06-04 19:08:56 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-04 19:12:49 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/71650) linux_chromium_gn_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel/builds/13280)
6 years, 6 months ago (2014-06-04 19:12:49 UTC) #8
sdefresne
TBR=gab for //chrome/browser/importer TBR=zea for //chrome/browser/sync/test/integration TBR=sky for //chrome/browser/ui/bookmarks Those are just unit tests and ...
6 years, 6 months ago (2014-06-06 08:21:27 UTC) #9
sdefresne
The CQ bit was checked by sdefresne@chromium.org
6 years, 6 months ago (2014-06-06 08:26:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sdefresne@chromium.org/306143003/20001
6 years, 6 months ago (2014-06-06 08:28:57 UTC) #11
commit-bot: I haz the power
Change committed as 275360
6 years, 6 months ago (2014-06-06 09:56:11 UTC) #12
gab
6 years, 6 months ago (2014-06-06 14:05:26 UTC) #13
Message was sent while issue was closed.
lgtm stamp for c/b/importer

Powered by Google App Engine
This is Rietveld 408576698