Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Side by Side Diff: chrome/browser/history/DEPS

Issue 306143003: Remove the BookmarkService interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@371825.2
Patch Set: Rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/history/android/bookmark_model_sql_handler_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 include_rules = [ 1 include_rules = [
2 # History is being made into a Browser Component, so we have these 2 # History is being made into a Browser Component, so we have these
3 # basic rules followed by temporary exceptions. Please don't 3 # basic rules followed by temporary exceptions. Please don't
4 # add to the list of exceptions! 4 # add to the list of exceptions!
5 "-chrome/browser", 5 "-chrome/browser",
6 "+chrome/browser/chrome_notification_types.h", 6 "+chrome/browser/chrome_notification_types.h",
7 "+chrome/browser/common", 7 "+chrome/browser/common",
8 "+chrome/browser/favicon", 8 "+chrome/browser/favicon",
9 "+chrome/browser/history", 9 "+chrome/browser/history",
10 "+chrome/browser/network_time", 10 "+chrome/browser/network_time",
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 "!chrome/browser/signin/signin_manager_factory.h", 42 "!chrome/browser/signin/signin_manager_factory.h",
43 "!chrome/browser/signin/token_service_factory.h", 43 "!chrome/browser/signin/token_service_factory.h",
44 "!chrome/browser/sync/profile_sync_service.h", 44 "!chrome/browser/sync/profile_sync_service.h",
45 "!chrome/browser/sync/profile_sync_service_factory.h", 45 "!chrome/browser/sync/profile_sync_service_factory.h",
46 "!chrome/browser/ui/browser.h", 46 "!chrome/browser/ui/browser.h",
47 "!chrome/browser/ui/browser_finder.h", 47 "!chrome/browser/ui/browser_finder.h",
48 "!chrome/browser/ui/profile_error_dialog.h", 48 "!chrome/browser/ui/profile_error_dialog.h",
49 "!chrome/browser/ui/webui/ntp/most_visited_handler.h", 49 "!chrome/browser/ui/webui/ntp/most_visited_handler.h",
50 "!chrome/browser/ui/webui/ntp/new_tab_ui.h", 50 "!chrome/browser/ui/webui/ntp/new_tab_ui.h",
51 "!components/bookmarks/browser/bookmark_model.h", 51 "!components/bookmarks/browser/bookmark_model.h",
52 "!components/bookmarks/browser/bookmark_service.h",
53 "!components/bookmarks/browser/bookmark_utils.h", 52 "!components/bookmarks/browser/bookmark_utils.h",
54 ] 53 ]
55 54
56 specific_include_rules = { 55 specific_include_rules = {
57 # Browser tests, by definition, need access to the browser objects. 56 # Browser tests, by definition, need access to the browser objects.
58 '.*_(api|browser|)test\.cc': [ 57 '.*_(api|browser|)test\.cc': [
59 "+chrome/browser", 58 "+chrome/browser",
60 ], 59 ],
61 # TODO(erikwright): Bring this list to zero. 60 # TODO(erikwright): Bring this list to zero.
62 # 61 #
63 # Do not add to the list of temporarily-allowed dependencies below, 62 # Do not add to the list of temporarily-allowed dependencies below,
64 # and please do not introduce more #includes of these files. 63 # and please do not introduce more #includes of these files.
65 '.*_[a-z]*test\.cc': [ 64 '.*_[a-z]*test\.cc': [
66 "!chrome/browser/bookmarks/bookmark_test_helpers.h", 65 "!chrome/browser/bookmarks/bookmark_test_helpers.h",
67 "!chrome/browser/bookmarks/bookmark_utils.h", 66 "!chrome/browser/bookmarks/bookmark_utils.h",
68 ] 67 ]
69 } 68 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/history/android/bookmark_model_sql_handler_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698