Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 306123005: [DevTools] Fix responsive design UI issues. (Closed)

Created:
6 years, 6 months ago by dgozman
Modified:
6 years, 6 months ago
Reviewers:
apavlov, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

[DevTools] Fix responsive design UI issues. BUG=327641 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175195

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -10 lines) Patch
M Source/devtools/front_end/ResponsiveDesignView.js View 3 chunks +2 lines, -7 lines 2 comments Download
M Source/devtools/front_end/sdk/OverridesSupport.js View 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
dgozman
Could you please take a look?
6 years, 6 months ago (2014-05-30 15:36:04 UTC) #1
apavlov
lgtm https://codereview.chromium.org/306123005/diff/1/Source/devtools/front_end/ResponsiveDesignView.js File Source/devtools/front_end/ResponsiveDesignView.js (right): https://codereview.chromium.org/306123005/diff/1/Source/devtools/front_end/ResponsiveDesignView.js#newcode96 Source/devtools/front_end/ResponsiveDesignView.js:96: if (!enabled && this._enabled) { "else if" ?
6 years, 6 months ago (2014-05-30 15:42:13 UTC) #2
dgozman
https://codereview.chromium.org/306123005/diff/1/Source/devtools/front_end/ResponsiveDesignView.js File Source/devtools/front_end/ResponsiveDesignView.js (right): https://codereview.chromium.org/306123005/diff/1/Source/devtools/front_end/ResponsiveDesignView.js#newcode96 Source/devtools/front_end/ResponsiveDesignView.js:96: if (!enabled && this._enabled) { On 2014/05/30 15:42:14, apavlov ...
6 years, 6 months ago (2014-05-31 05:48:18 UTC) #3
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 6 months ago (2014-05-31 05:48:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/306123005/1
6 years, 6 months ago (2014-05-31 05:48:50 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 6 months ago (2014-05-31 07:06:27 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-31 07:06:41 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/12600)
6 years, 6 months ago (2014-05-31 07:06:42 UTC) #8
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 6 months ago (2014-05-31 07:15:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/306123005/1
6 years, 6 months ago (2014-05-31 07:15:22 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 6 months ago (2014-05-31 07:15:40 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-31 07:15:51 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/12600)
6 years, 6 months ago (2014-05-31 07:15:52 UTC) #13
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 6 months ago (2014-05-31 08:02:18 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/306123005/1
6 years, 6 months ago (2014-05-31 08:02:33 UTC) #15
commit-bot: I haz the power
6 years, 6 months ago (2014-05-31 08:02:53 UTC) #16
Message was sent while issue was closed. 
Change committed as 175195

Powered by Google App Engine
This is Rietveld 408576698