Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1845)

Unified Diff: Source/devtools/front_end/sdk/OverridesSupport.js

Issue 306123005: [DevTools] Fix responsive design UI issues. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/sdk/OverridesSupport.js
diff --git a/Source/devtools/front_end/sdk/OverridesSupport.js b/Source/devtools/front_end/sdk/OverridesSupport.js
index 2b378e9891798b401bf0776c1ce7dd5a1ba58dfd..b5c12c4bd36f34b8d04ee4f879692829fad79e3a 100644
--- a/Source/devtools/front_end/sdk/OverridesSupport.js
+++ b/Source/devtools/front_end/sdk/OverridesSupport.js
@@ -508,7 +508,8 @@ WebInspector.OverridesSupport.prototype = {
return;
var userAgent = this.settings.overrideUserAgent.get() ? this.settings.userAgent.get() : "";
NetworkAgent.setUserAgentOverride(userAgent);
- this._updateUserAgentWarningMessage(this._userAgent !== userAgent ? WebInspector.UIString("You might need to reload the page for proper user agent spoofing and viewport rendering.") : "");
+ if (this._userAgent !== userAgent)
+ this._updateUserAgentWarningMessage(WebInspector.UIString("You might need to reload the page for proper user agent spoofing and viewport rendering."));
this._userAgent = userAgent;
this.maybeHasActiveOverridesChanged();
},
@@ -610,8 +611,8 @@ WebInspector.OverridesSupport.prototype = {
var overrideDeviceResolution = this.settings.overrideDeviceResolution.get();
var viewportEnabled = this.settings.emulateViewport.get();
- this._updateDeviceMetricsWarningMessage(this._overrideDeviceResolution !== overrideDeviceResolution || this._emulateViewportEnabled != viewportEnabled ?
- WebInspector.UIString("You might need to reload the page for proper user agent spoofing and viewport rendering.") : "");
+ if (this._overrideDeviceResolution !== overrideDeviceResolution || this._emulateViewportEnabled !== viewportEnabled)
+ this._updateDeviceMetricsWarningMessage(WebInspector.UIString("You might need to reload the page for proper user agent spoofing and viewport rendering."));
this._overrideDeviceResolution = overrideDeviceResolution;
this._emulateViewportEnabled = viewportEnabled;
this._deviceMetricsOverrideAppliedForTest();
@@ -716,6 +717,7 @@ WebInspector.OverridesSupport.prototype = {
{
this._deviceMetricsChanged();
this._updateUserAgentWarningMessage("");
+ this._updateDeviceMetricsWarningMessage("");
},
/**

Powered by Google App Engine
This is Rietveld 408576698